@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Conpherence - fix fatal if you don't have conpherences
Summary: Fixes T7721. Looks like this got renamed at some point but skipped. Also, change the true / false idx look ups to correct integers here since there's a warning in the error logs in this case without it.
Test Plan: made new user. loaded up conpherence and it worked. tried all the links too for good measure and they worked
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T7717, T7721
Differential Revision: https://secure.phabricator.com/D12243
+3
-3
+3
-3
src/applications/conpherence/view/ConpherenceThreadListView.php
+3
-3
src/applications/conpherence/view/ConpherenceThreadListView.php
···
22
22
require_celerity_resource('conpherence-menu-css');
23
23
24
24
$grouped = mgroup($this->threads, 'getIsRoom');
25
-
$rooms = idx($grouped, true, array());
25
+
$rooms = idx($grouped, 1, array());
26
26
27
27
$policies = array();
28
28
foreach ($rooms as $room) {
···
41
41
->setID('conpherence-menu');
42
42
43
43
$this->addRoomsToMenu($menu, $rooms, $policy_objects);
44
-
$messages = idx($grouped, false, array());
44
+
$messages = idx($grouped, 0, array());
45
45
$this->addMessagesToMenu($menu, $messages);
46
46
47
47
return $menu;
···
164
164
$menu->addMenuItem($header);
165
165
166
166
if (empty($conpherences)) {
167
-
$menu->addMenuItem($this->getNoConpherencesMenuItem());
167
+
$menu->addMenuItem($this->getNoMessagesMenuItem());
168
168
return $menu;
169
169
}
170
170