@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix call to isGlobalDragAndDropUploadEnabled() from pages with no controller
Summary: Fixes T7902. Some kinds of error pages, including the 404 page, may not have a controller when they reach this method.
Test Plan: Hit 404 page.
Reviewers: btrahan
Reviewed By: btrahan
Subscribers: epriestley
Maniphest Tasks: T7902
Differential Revision: https://secure.phabricator.com/D12538
+7
-1
+7
-1
src/view/page/PhabricatorStandardPageView.php
+7
-1
src/view/page/PhabricatorStandardPageView.php
···
643
643
if ($console) {
644
644
$console_config = $this->getConsoleConfig();
645
645
}
646
+
647
+
$upload_enabled = false;
648
+
if ($controller) {
649
+
$upload_enabled = $controller->isGlobalDragAndDropUploadEnabled();
650
+
}
651
+
646
652
return array(
647
653
'title' => $this->getTitle(),
648
654
'aphlictDropdownData' => array(
649
655
$dropdown_query->getNotificationData(),
650
656
$dropdown_query->getConpherenceData(),
651
657
),
652
-
'globalDragAndDrop' => $controller->isGlobalDragAndDropUploadEnabled(),
658
+
'globalDragAndDrop' => $upload_enabled,
653
659
'aphlictDropdowns' => $rendered_dropdowns,
654
660
'hisecWarningConfig' => $hisec_warning_config,
655
661
'consoleConfig' => $console_config,