@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Add spaces when rendering PhabricatorPropertyListView
Summary:
Ref T2319. In a property list view, if there's a property like:
Property Name propertyvalue
...and you double click "propertyvalue" to select it so you can copy paste it (maybe it's a branch name or a URI), you get "Namepropertyvalue" (or worse). Although this "fix" is hacky, it seems to work alright and not cause side effects.
Adding spaces between the tags instead (`<dt>x</dt> <dd>y</dd>`) did not work in Safari. Adding a `<span> </span>` between the tags did, but that seems even messier.
Test Plan: Double-clicked "propertyvalue".
Reviewers: chad, btrahan
Reviewed By: chad
CC: aran
Maniphest Tasks: T2319
Differential Revision: https://secure.phabricator.com/D6026
+6
-2
+6
-2
src/view/layout/PhabricatorPropertyListView.php
+6
-2
src/view/layout/PhabricatorPropertyListView.php
···
121
121
$key = $spec['key'];
122
122
$value = $spec['value'];
123
123
124
+
// NOTE: We append a space to each value to improve the behavior when the
125
+
// user double-clicks a property value (like a URI) to select it. Without
126
+
// the space, the label is also selected.
127
+
124
128
$items[] = phutil_tag(
125
129
'dt',
126
130
array(
127
131
'class' => 'phabricator-property-list-key',
128
132
),
129
-
$key);
133
+
array($key, ' '));
130
134
131
135
$items[] = phutil_tag(
132
136
'dd',
133
137
array(
134
138
'class' => 'phabricator-property-list-value',
135
139
),
136
-
$value);
140
+
array($value, ' '));
137
141
}
138
142
139
143
$list = phutil_tag(