@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Clean up an old transaction state flag
Summary: Depends on D19289. Ref T13110. This flag has been obsolete for some time and has no callers.
Test Plan: Grepped for `hasReviewTransaction`, no hits.
Maniphest Tasks: T13110
Differential Revision: https://secure.phabricator.com/D19290
-8
-8
src/applications/differential/editor/DifferentialTransactionEditor.php
-8
src/applications/differential/editor/DifferentialTransactionEditor.php
···
7
7
private $isCloseByCommit;
8
8
private $repositoryPHIDOverride = false;
9
9
private $didExpandInlineState = false;
10
-
private $hasReviewTransaction = false;
11
10
private $affectedPaths;
12
11
private $firstBroadcast = false;
13
12
private $wasBroadcasting;
···
127
126
// If we have an "Inline State" transaction already, the caller
128
127
// built it for us so we don't need to expand it again.
129
128
$this->didExpandInlineState = true;
130
-
break;
131
-
case DifferentialRevisionAcceptTransaction::TRANSACTIONTYPE:
132
-
case DifferentialRevisionRejectTransaction::TRANSACTIONTYPE:
133
-
case DifferentialRevisionResignTransaction::TRANSACTIONTYPE:
134
-
// If we have a review transaction, we'll skip marking the user
135
-
// as "Commented" later. This should get cleaner after T10967.
136
-
$this->hasReviewTransaction = true;
137
129
break;
138
130
case DifferentialRevisionPlanChangesTransaction::TRANSACTIONTYPE:
139
131
if ($xaction->getMetadataValue('draft.demote')) {