@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Convert Passhrase to handleRequest
Summary: Converts Passphrase
Test Plan: New Cred, Edit Cred, Lock, view, destroy
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: epriestley, Korvin
Maniphest Tasks: T8628
Differential Revision: https://secure.phabricator.com/D13726
+34
-81
+4
-10
src/applications/passphrase/controller/PassphraseCredentialConduitController.php
+4
-10
src/applications/passphrase/controller/PassphraseCredentialConduitController.php
···
3
3
final class PassphraseCredentialConduitController
4
4
extends PassphraseController {
5
5
6
-
private $id;
7
-
8
-
public function willProcessRequest(array $data) {
9
-
$this->id = $data['id'];
10
-
}
11
-
12
-
public function processRequest() {
13
-
$request = $this->getRequest();
14
-
$viewer = $request->getUser();
6
+
public function handleRequest(AphrontRequest $request) {
7
+
$viewer = $request->getViewer();
8
+
$id = $request->getURIData('id');
15
9
16
10
$credential = id(new PassphraseCredentialQuery())
17
11
->setViewer($viewer)
18
-
->withIDs(array($this->id))
12
+
->withIDs(array($id))
19
13
->requireCapabilities(
20
14
array(
21
15
PhabricatorPolicyCapability::CAN_VIEW,
+2
-3
src/applications/passphrase/controller/PassphraseCredentialCreateController.php
+2
-3
src/applications/passphrase/controller/PassphraseCredentialCreateController.php
···
2
2
3
3
final class PassphraseCredentialCreateController extends PassphraseController {
4
4
5
-
public function processRequest() {
6
-
$request = $this->getRequest();
7
-
$viewer = $request->getUser();
5
+
public function handleRequest(AphrontRequest $request) {
6
+
$viewer = $request->getViewer();
8
7
9
8
$types = PassphraseCredentialType::getAllCreateableTypes();
10
9
$types = mpull($types, null, 'getCredentialType');
+4
-10
src/applications/passphrase/controller/PassphraseCredentialDestroyController.php
+4
-10
src/applications/passphrase/controller/PassphraseCredentialDestroyController.php
···
3
3
final class PassphraseCredentialDestroyController
4
4
extends PassphraseController {
5
5
6
-
private $id;
7
-
8
-
public function willProcessRequest(array $data) {
9
-
$this->id = $data['id'];
10
-
}
11
-
12
-
public function processRequest() {
13
-
$request = $this->getRequest();
14
-
$viewer = $request->getUser();
6
+
public function handleRequest(AphrontRequest $request) {
7
+
$viewer = $request->getViewer();
8
+
$id = $request->getURIData('id');
15
9
16
10
$credential = id(new PassphraseCredentialQuery())
17
11
->setViewer($viewer)
18
-
->withIDs(array($this->id))
12
+
->withIDs(array($id))
19
13
->requireCapabilities(
20
14
array(
21
15
PhabricatorPolicyCapability::CAN_VIEW,
+5
-11
src/applications/passphrase/controller/PassphraseCredentialEditController.php
+5
-11
src/applications/passphrase/controller/PassphraseCredentialEditController.php
···
2
2
3
3
final class PassphraseCredentialEditController extends PassphraseController {
4
4
5
-
private $id;
6
-
7
-
public function willProcessRequest(array $data) {
8
-
$this->id = idx($data, 'id');
9
-
}
10
-
11
-
public function processRequest() {
12
-
$request = $this->getRequest();
13
-
$viewer = $request->getUser();
5
+
public function handleRequest(AphrontRequest $request) {
6
+
$viewer = $request->getViewer();
7
+
$id = $request->getURIData('id');
14
8
15
-
if ($this->id) {
9
+
if ($id) {
16
10
$credential = id(new PassphraseCredentialQuery())
17
11
->setViewer($viewer)
18
-
->withIDs(array($this->id))
12
+
->withIDs(array($id))
19
13
->requireCapabilities(
20
14
array(
21
15
PhabricatorPolicyCapability::CAN_VIEW,
+3
-7
src/applications/passphrase/controller/PassphraseCredentialListController.php
+3
-7
src/applications/passphrase/controller/PassphraseCredentialListController.php
···
2
2
3
3
final class PassphraseCredentialListController extends PassphraseController {
4
4
5
-
private $queryKey;
6
-
7
5
public function shouldAllowPublic() {
8
6
return true;
9
7
}
10
8
11
-
public function willProcessRequest(array $data) {
12
-
$this->queryKey = idx($data, 'queryKey');
13
-
}
9
+
public function handleRequest(AphrontRequest $request) {
10
+
$querykey = $request->getURIData('queryKey');
14
11
15
-
public function processRequest() {
16
12
$controller = id(new PhabricatorApplicationSearchController())
17
-
->setQueryKey($this->queryKey)
13
+
->setQueryKey($querykey)
18
14
->setSearchEngine(new PassphraseCredentialSearchEngine())
19
15
->setNavigation($this->buildSideNavView());
20
16
+4
-10
src/applications/passphrase/controller/PassphraseCredentialLockController.php
+4
-10
src/applications/passphrase/controller/PassphraseCredentialLockController.php
···
3
3
final class PassphraseCredentialLockController
4
4
extends PassphraseController {
5
5
6
-
private $id;
7
-
8
-
public function willProcessRequest(array $data) {
9
-
$this->id = $data['id'];
10
-
}
11
-
12
-
public function processRequest() {
13
-
$request = $this->getRequest();
14
-
$viewer = $request->getUser();
6
+
public function handleRequest(AphrontRequest $request) {
7
+
$viewer = $request->getViewer();
8
+
$id = $request->getURIData('id');
15
9
16
10
$credential = id(new PassphraseCredentialQuery())
17
11
->setViewer($viewer)
18
-
->withIDs(array($this->id))
12
+
->withIDs(array($id))
19
13
->requireCapabilities(
20
14
array(
21
15
PhabricatorPolicyCapability::CAN_VIEW,
+4
-10
src/applications/passphrase/controller/PassphraseCredentialPublicController.php
+4
-10
src/applications/passphrase/controller/PassphraseCredentialPublicController.php
···
3
3
final class PassphraseCredentialPublicController
4
4
extends PassphraseController {
5
5
6
-
private $id;
7
-
8
-
public function willProcessRequest(array $data) {
9
-
$this->id = $data['id'];
10
-
}
11
-
12
-
public function processRequest() {
13
-
$request = $this->getRequest();
14
-
$viewer = $request->getUser();
6
+
public function handleRequest(AphrontRequest $request) {
7
+
$viewer = $request->getViewer();
8
+
$id = $request->getURIData('id');
15
9
16
10
$credential = id(new PassphraseCredentialQuery())
17
11
->setViewer($viewer)
18
-
->withIDs(array($this->id))
12
+
->withIDs(array($id))
19
13
->requireCapabilities(
20
14
array(
21
15
PhabricatorPolicyCapability::CAN_VIEW,
+4
-10
src/applications/passphrase/controller/PassphraseCredentialRevealController.php
+4
-10
src/applications/passphrase/controller/PassphraseCredentialRevealController.php
···
3
3
final class PassphraseCredentialRevealController
4
4
extends PassphraseController {
5
5
6
-
private $id;
7
-
8
-
public function willProcessRequest(array $data) {
9
-
$this->id = $data['id'];
10
-
}
11
-
12
-
public function processRequest() {
13
-
$request = $this->getRequest();
14
-
$viewer = $request->getUser();
6
+
public function handleRequest(AphrontRequest $request) {
7
+
$viewer = $request->getViewer();
8
+
$id = $request->getURIData('id');
15
9
16
10
$credential = id(new PassphraseCredentialQuery())
17
11
->setViewer($viewer)
18
-
->withIDs(array($this->id))
12
+
->withIDs(array($id))
19
13
->requireCapabilities(
20
14
array(
21
15
PhabricatorPolicyCapability::CAN_VIEW,
+4
-10
src/applications/passphrase/controller/PassphraseCredentialViewController.php
+4
-10
src/applications/passphrase/controller/PassphraseCredentialViewController.php
···
2
2
3
3
final class PassphraseCredentialViewController extends PassphraseController {
4
4
5
-
private $id;
6
-
7
-
public function willProcessRequest(array $data) {
8
-
$this->id = $data['id'];
9
-
}
10
-
11
-
public function processRequest() {
12
-
$request = $this->getRequest();
13
-
$viewer = $request->getUser();
5
+
public function handleRequest(AphrontRequest $request) {
6
+
$viewer = $request->getViewer();
7
+
$id = $request->getURIData('id');
14
8
15
9
$credential = id(new PassphraseCredentialQuery())
16
10
->setViewer($viewer)
17
-
->withIDs(array($this->id))
11
+
->withIDs(array($id))
18
12
->executeOne();
19
13
if (!$credential) {
20
14
return new Aphront404Response();