@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Change background for image views in Differential
Summary:
Many images in Differential changesets are icons designed for
use on dark backgrounds. This makes them invisible on Differential's
white background. This adds an option to use a darker background
instead so you can see the images.
Currently this behavior is triggered on hover. (Also, it's a rather
garish fuchsia.) It seems fine UX-wise but I'm not totally sure of it.
Test Plan:
Load diff containing grippy_texture. Marvel at the grippy
fuchsia.
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D3272
+39
-17
+30
-16
src/__celerity_resource_map__.php
+30
-16
src/__celerity_resource_map__.php
···
168
168
'disk' => '/rsrc/image/button_menu.png',
169
169
'type' => 'png',
170
170
),
171
+
'/rsrc/image/checker_dark.png' =>
172
+
array(
173
+
'hash' => '640f795343df76ebe5409aae6187e57f',
174
+
'uri' => '/res/640f7953/rsrc/image/checker_dark.png',
175
+
'disk' => '/rsrc/image/checker_dark.png',
176
+
'type' => 'png',
177
+
),
178
+
'/rsrc/image/checker_light.png' =>
179
+
array(
180
+
'hash' => '7f8f3ef8beb0f2cc4cc69efb9e1c3308',
181
+
'uri' => '/res/7f8f3ef8/rsrc/image/checker_light.png',
182
+
'disk' => '/rsrc/image/checker_light.png',
183
+
'type' => 'png',
184
+
),
171
185
'/rsrc/image/credit_cards.png' =>
172
186
array(
173
187
'hash' => '681448de424ea159b6ea68af04c046ae',
···
846
860
),
847
861
'differential-changeset-view-css' =>
848
862
array(
849
-
'uri' => '/res/c9706669/rsrc/css/application/differential/changeset-view.css',
863
+
'uri' => '/res/28449eff/rsrc/css/application/differential/changeset-view.css',
850
864
'type' => 'css',
851
865
'requires' =>
852
866
array(
···
3083
3097
'uri' => '/res/pkg/971b021e/core.pkg.js',
3084
3098
'type' => 'js',
3085
3099
),
3086
-
'96bc37d6' =>
3100
+
'19ebcc79' =>
3087
3101
array(
3088
3102
'name' => 'differential.pkg.css',
3089
3103
'symbols' =>
···
3102
3116
11 => 'differential-local-commits-view-css',
3103
3117
12 => 'inline-comment-summary-css',
3104
3118
),
3105
-
'uri' => '/res/pkg/96bc37d6/differential.pkg.css',
3119
+
'uri' => '/res/pkg/19ebcc79/differential.pkg.css',
3106
3120
'type' => 'css',
3107
3121
),
3108
3122
29296904 =>
···
3225
3239
'aphront-dialog-view-css' => 'edf6b149',
3226
3240
'aphront-error-view-css' => 'edf6b149',
3227
3241
'aphront-form-view-css' => 'edf6b149',
3228
-
'aphront-headsup-action-list-view-css' => '96bc37d6',
3242
+
'aphront-headsup-action-list-view-css' => '19ebcc79',
3229
3243
'aphront-headsup-view-css' => 'edf6b149',
3230
3244
'aphront-list-filter-view-css' => 'edf6b149',
3231
3245
'aphront-pager-view-css' => 'edf6b149',
···
3235
3249
'aphront-tokenizer-control-css' => 'edf6b149',
3236
3250
'aphront-tooltip-css' => 'edf6b149',
3237
3251
'aphront-typeahead-control-css' => 'edf6b149',
3238
-
'differential-changeset-view-css' => '96bc37d6',
3239
-
'differential-core-view-css' => '96bc37d6',
3252
+
'differential-changeset-view-css' => '19ebcc79',
3253
+
'differential-core-view-css' => '19ebcc79',
3240
3254
'differential-inline-comment-editor' => '29296904',
3241
-
'differential-local-commits-view-css' => '96bc37d6',
3242
-
'differential-results-table-css' => '96bc37d6',
3243
-
'differential-revision-add-comment-css' => '96bc37d6',
3244
-
'differential-revision-comment-css' => '96bc37d6',
3245
-
'differential-revision-comment-list-css' => '96bc37d6',
3246
-
'differential-revision-history-css' => '96bc37d6',
3247
-
'differential-table-of-contents-css' => '96bc37d6',
3255
+
'differential-local-commits-view-css' => '19ebcc79',
3256
+
'differential-results-table-css' => '19ebcc79',
3257
+
'differential-revision-add-comment-css' => '19ebcc79',
3258
+
'differential-revision-comment-css' => '19ebcc79',
3259
+
'differential-revision-comment-list-css' => '19ebcc79',
3260
+
'differential-revision-history-css' => '19ebcc79',
3261
+
'differential-table-of-contents-css' => '19ebcc79',
3248
3262
'diffusion-commit-view-css' => 'c8ce2d88',
3249
3263
'diffusion-icons-css' => 'c8ce2d88',
3250
-
'inline-comment-summary-css' => '96bc37d6',
3264
+
'inline-comment-summary-css' => '19ebcc79',
3251
3265
'javelin-behavior' => '6fb20113',
3252
3266
'javelin-behavior-aphront-basic-tokenizer' => '97f65640',
3253
3267
'javelin-behavior-aphront-drag-and-drop' => '29296904',
···
3301
3315
'maniphest-task-summary-css' => '7839ae2d',
3302
3316
'maniphest-transaction-detail-css' => '7839ae2d',
3303
3317
'phabricator-app-buttons-css' => 'edf6b149',
3304
-
'phabricator-content-source-view-css' => '96bc37d6',
3318
+
'phabricator-content-source-view-css' => '19ebcc79',
3305
3319
'phabricator-core-buttons-css' => 'edf6b149',
3306
3320
'phabricator-core-css' => 'edf6b149',
3307
3321
'phabricator-directory-css' => 'edf6b149',
···
3312
3326
'phabricator-keyboard-shortcut' => '971b021e',
3313
3327
'phabricator-keyboard-shortcut-manager' => '971b021e',
3314
3328
'phabricator-menu-item' => '971b021e',
3315
-
'phabricator-object-selector-css' => '96bc37d6',
3329
+
'phabricator-object-selector-css' => '19ebcc79',
3316
3330
'phabricator-paste-file-upload' => '971b021e',
3317
3331
'phabricator-prefab' => '971b021e',
3318
3332
'phabricator-project-tag-css' => '7839ae2d',
+1
-1
src/applications/differential/parser/DifferentialChangesetParser.php
+1
-1
src/applications/differential/parser/DifferentialChangesetParser.php
+8
webroot/rsrc/css/application/differential/changeset-view.css
+8
webroot/rsrc/css/application/differential/changeset-view.css
···
172
172
font-weight: bold;
173
173
}
174
174
175
+
.differential-diff .differential-image-diff {
176
+
background-image: url(/rsrc/image/checker_light.png);
177
+
}
178
+
179
+
.differential-diff .differential-image-diff:hover {
180
+
background-image: url(/rsrc/image/checker_dark.png);
181
+
}
182
+
175
183
.differential-meta-notice {
176
184
border: 1px solid #ffdd99;
177
185
background: #ffeeaa;
webroot/rsrc/image/checker_dark.png
webroot/rsrc/image/checker_dark.png
This is a binary file and will not be displayed.
webroot/rsrc/image/checker_light.png
webroot/rsrc/image/checker_light.png
This is a binary file and will not be displayed.