recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Make "Home" a formal application

Summary: Ref T3979. Currently, the home page lives in an old application called "directory" and is informally defined. Make it a real application called "Home", with a formal definition. It isn't launchable and can't be uninstalled.

Test Plan: Loaded home, saw exact same stuff.

Reviewers: chad, btrahan

Reviewed By: chad

CC: aran

Maniphest Tasks: T3979

Differential Revision: https://secure.phabricator.com/D8074

epriestley 6fdbc406 e26fbbf9

+40 -10
+6 -4
src/__phutil_library_map__.php
··· 1087 1087 'PhabricatorApplicationFlags' => 'applications/flag/application/PhabricatorApplicationFlags.php', 1088 1088 'PhabricatorApplicationHarbormaster' => 'applications/harbormaster/application/PhabricatorApplicationHarbormaster.php', 1089 1089 'PhabricatorApplicationHerald' => 'applications/herald/application/PhabricatorApplicationHerald.php', 1090 + 'PhabricatorApplicationHome' => 'applications/home/application/PhabricatorApplicationHome.php', 1090 1091 'PhabricatorApplicationLaunchView' => 'applications/meta/view/PhabricatorApplicationLaunchView.php', 1091 1092 'PhabricatorApplicationLegalpad' => 'applications/legalpad/application/PhabricatorApplicationLegalpad.php', 1092 1093 'PhabricatorApplicationMacro' => 'applications/macro/application/PhabricatorApplicationMacro.php', ··· 1385 1386 'PhabricatorDifferentialConfigOptions' => 'applications/differential/config/PhabricatorDifferentialConfigOptions.php', 1386 1387 'PhabricatorDifferentialRevisionTestDataGenerator' => 'applications/differential/lipsum/PhabricatorDifferentialRevisionTestDataGenerator.php', 1387 1388 'PhabricatorDiffusionConfigOptions' => 'applications/diffusion/config/PhabricatorDiffusionConfigOptions.php', 1388 - 'PhabricatorDirectoryController' => 'applications/directory/controller/PhabricatorDirectoryController.php', 1389 - 'PhabricatorDirectoryMainController' => 'applications/directory/controller/PhabricatorDirectoryMainController.php', 1390 1389 'PhabricatorDisabledUserController' => 'applications/auth/controller/PhabricatorDisabledUserController.php', 1391 1390 'PhabricatorDisqusConfigOptions' => 'applications/config/option/PhabricatorDisqusConfigOptions.php', 1392 1391 'PhabricatorDraft' => 'applications/draft/storage/PhabricatorDraft.php', ··· 1528 1527 'PhabricatorHashTestCase' => 'infrastructure/util/__tests__/PhabricatorHashTestCase.php', 1529 1528 'PhabricatorHelpController' => 'applications/help/controller/PhabricatorHelpController.php', 1530 1529 'PhabricatorHelpKeyboardShortcutController' => 'applications/help/controller/PhabricatorHelpKeyboardShortcutController.php', 1530 + 'PhabricatorHomeController' => 'applications/home/controller/PhabricatorHomeController.php', 1531 + 'PhabricatorHomeMainController' => 'applications/home/controller/PhabricatorHomeMainController.php', 1531 1532 'PhabricatorHovercardExample' => 'applications/uiexample/examples/PhabricatorHovercardExample.php', 1532 1533 'PhabricatorHovercardView' => 'view/widget/hovercard/PhabricatorHovercardView.php', 1533 1534 'PhabricatorIRCBot' => 'infrastructure/daemon/bot/PhabricatorIRCBot.php', ··· 3671 3672 'PhabricatorApplicationFlags' => 'PhabricatorApplication', 3672 3673 'PhabricatorApplicationHarbormaster' => 'PhabricatorApplication', 3673 3674 'PhabricatorApplicationHerald' => 'PhabricatorApplication', 3675 + 'PhabricatorApplicationHome' => 'PhabricatorApplication', 3674 3676 'PhabricatorApplicationLaunchView' => 'AphrontView', 3675 3677 'PhabricatorApplicationLegalpad' => 'PhabricatorApplication', 3676 3678 'PhabricatorApplicationMacro' => 'PhabricatorApplication', ··· 4010 4012 'PhabricatorDifferentialConfigOptions' => 'PhabricatorApplicationConfigOptions', 4011 4013 'PhabricatorDifferentialRevisionTestDataGenerator' => 'PhabricatorTestDataGenerator', 4012 4014 'PhabricatorDiffusionConfigOptions' => 'PhabricatorApplicationConfigOptions', 4013 - 'PhabricatorDirectoryController' => 'PhabricatorController', 4014 - 'PhabricatorDirectoryMainController' => 'PhabricatorDirectoryController', 4015 4015 'PhabricatorDisabledUserController' => 'PhabricatorAuthController', 4016 4016 'PhabricatorDisqusConfigOptions' => 'PhabricatorApplicationConfigOptions', 4017 4017 'PhabricatorDraft' => 'PhabricatorDraftDAO', ··· 4173 4173 'PhabricatorHashTestCase' => 'PhabricatorTestCase', 4174 4174 'PhabricatorHelpController' => 'PhabricatorController', 4175 4175 'PhabricatorHelpKeyboardShortcutController' => 'PhabricatorHelpController', 4176 + 'PhabricatorHomeController' => 'PhabricatorController', 4177 + 'PhabricatorHomeMainController' => 'PhabricatorHomeController', 4176 4178 'PhabricatorHovercardExample' => 'PhabricatorUIExample', 4177 4179 'PhabricatorHovercardView' => 'AphrontView', 4178 4180 'PhabricatorIRCBot' => 'PhabricatorDaemon',
-3
src/aphront/configuration/AphrontDefaultApplicationConfiguration.php
··· 16 16 17 17 public function getURIMap() { 18 18 return $this->getResourceURIMapRules() + array( 19 - '/(?:(?P<filter>(?:jump))/)?' => 20 - 'PhabricatorDirectoryMainController', 21 - 22 19 '/typeahead/' => array( 23 20 'common/(?P<type>\w+)/' 24 21 => 'PhabricatorTypeaheadCommonDatasourceController',
+1 -1
src/applications/directory/controller/PhabricatorDirectoryController.php src/applications/home/controller/PhabricatorHomeController.php
··· 1 1 <?php 2 2 3 - abstract class PhabricatorDirectoryController extends PhabricatorController { 3 + abstract class PhabricatorHomeController extends PhabricatorController { 4 4 5 5 public function buildStandardPageResponse($view, array $data) { 6 6 $page = $this->buildStandardPageView();
+2 -2
src/applications/directory/controller/PhabricatorDirectoryMainController.php src/applications/home/controller/PhabricatorHomeMainController.php
··· 1 1 <?php 2 2 3 - final class PhabricatorDirectoryMainController 4 - extends PhabricatorDirectoryController { 3 + final class PhabricatorHomeMainController 4 + extends PhabricatorHomeController { 5 5 6 6 private $filter; 7 7 private $minipanels = array();
+31
src/applications/home/application/PhabricatorApplicationHome.php
··· 1 + <?php 2 + 3 + final class PhabricatorApplicationHome extends PhabricatorApplication { 4 + 5 + public function getBaseURI() { 6 + return '/'; 7 + } 8 + 9 + public function getShortDescription() { 10 + return pht('Where the Heart Is'); 11 + } 12 + 13 + public function getIconName() { 14 + return 'home'; 15 + } 16 + 17 + public function getRoutes() { 18 + return array( 19 + '/(?:(?P<filter>(?:jump))/)?' => 'PhabricatorHomeMainController', 20 + ); 21 + } 22 + 23 + public function shouldAppearInLaunchView() { 24 + return false; 25 + } 26 + 27 + public function canUninstall() { 28 + return false; 29 + } 30 + 31 + }