@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Disable the edit/quote menu for non-standard comments
Summary: Fixes T4930. We currently show the edit/quote menu if a transaction group has //inline// comments, but this doesn't make sense and doesn't work properly. Only show this menu if the group has a normal comment.
Test Plan:
Viewed these groups:
- Normal comment (edits fine).
- Just inlines (no more edit menu).
- Inline + comment (edits fine, affects the normal comment properly).
Reviewers: btrahan
Reviewed By: btrahan
Subscribers: bitglue, epriestley
Maniphest Tasks: T4930
Differential Revision: https://secure.phabricator.com/D9180
+14
-5
+14
-5
src/applications/transactions/view/PhabricatorApplicationTransactionView.php
+14
-5
src/applications/transactions/view/PhabricatorApplicationTransactionView.php
···
382
382
->setAnchor($anchor);
383
383
}
384
384
385
-
$has_deleted_comment = $xaction->getComment() &&
386
-
$xaction->getComment()->getIsDeleted();
385
+
$transaction_type = $xaction->getTransactionType();
386
+
$comment_type = PhabricatorTransactions::TYPE_COMMENT;
387
+
$is_normal_comment = ($transaction_type == $comment_type);
388
+
389
+
if ($this->getShowEditActions() &&
390
+
!$this->isPreview &&
391
+
$is_normal_comment) {
392
+
393
+
$has_deleted_comment =
394
+
$xaction->getComment() &&
395
+
$xaction->getComment()->getIsDeleted();
387
396
388
-
$has_removed_comment = $xaction->getComment() &&
389
-
$xaction->getComment()->getIsRemoved();
397
+
$has_removed_comment =
398
+
$xaction->getComment() &&
399
+
$xaction->getComment()->getIsRemoved();
390
400
391
-
if ($this->getShowEditActions() && !$this->isPreview) {
392
401
if ($xaction->getCommentVersion() > 1 && !$has_removed_comment) {
393
402
$event->setIsEdited(true);
394
403
}