@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix one straggler milestone URI
Summary: I missed this during cleanup.
Test Plan: Go to a project, then: Subprojects, Create Milestone, Cancel. No longer 404/fatals.
Reviewers: chad
Reviewed By: chad
Differential Revision: https://secure.phabricator.com/D15241
+4
-10
-2
src/applications/project/application/PhabricatorProjectApplication.php
-2
src/applications/project/application/PhabricatorProjectApplication.php
···
65
65
=> $this->getPanelRouting('PhabricatorProjectPanelController'),
66
66
'subprojects/(?P<id>[1-9]\d*)/'
67
67
=> 'PhabricatorProjectSubprojectsController',
68
-
'milestones/(?P<id>[1-9]\d*)/'
69
-
=> 'PhabricatorProjectMilestonesController',
70
68
'board/(?P<id>[1-9]\d*)/'.
71
69
'(?P<filter>filter/)?'.
72
70
'(?:query/(?P<queryKey>[^/]+)/)?'
+4
-8
src/applications/project/engine/PhabricatorProjectEditEngine.php
+4
-8
src/applications/project/engine/PhabricatorProjectEditEngine.php
···
88
88
89
89
protected function getObjectCreateCancelURI($object) {
90
90
$parent = $this->getParentProject();
91
-
if ($parent) {
92
-
$id = $parent->getID();
93
-
return "/project/subprojects/{$id}/";
94
-
}
95
-
96
91
$milestone = $this->getMilestoneProject();
97
-
if ($milestone) {
98
-
$id = $milestone->getID();
99
-
return "/project/milestones/{$id}/";
92
+
93
+
if ($parent || $milestone) {
94
+
$id = nonempty($parent, $milestone)->getID();
95
+
return "/project/subprojects/{$id}/";
100
96
}
101
97
102
98
return parent::getObjectCreateCancelURI($object);