@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix an issue with viewing an undiscovered commit in Diffusion
Summary: If you load Diffusion between a repository being pulled and discovered, you can end up with a valid commit reference that hasn't been discovered yet. Don't fatal.
Test Plan: Saw somewhat-helpful error page instead of fatal.
Reviewers: btrahan
Reviewed By: btrahan
CC: aran
Differential Revision: https://secure.phabricator.com/D7448
+3
-1
+3
-1
src/applications/diffusion/request/DiffusionRequest.php
+3
-1
src/applications/diffusion/request/DiffusionRequest.php
···
277
277
'repositoryID = %d AND commitIdentifier = %s',
278
278
$repository->getID(),
279
279
$this->getCommit());
280
-
$commit->attachRepository($repository);
280
+
if ($commit) {
281
+
$commit->attachRepository($repository);
282
+
}
281
283
$this->repositoryCommit = $commit;
282
284
}
283
285
return $this->repositoryCommit;