recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix a transaction editor "continue;" inside "switch()" for PHP 7.3

Summary: See <https://discourse.phabricator-community.org/t/new-git-commit-processing-fails-on-php-7-3/>. This "continue" should be a "break".

Test Plan:
{F6045490}

- Tried to assign a task to myself while I was already the owner, got an appropriate error.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D19844

epriestley 70bf63bc 9bfe5585

+1 -1
+1 -1
src/applications/maniphest/editor/ManiphestTransactionEditor.php
··· 649 649 $old_value = $object->getOwnerPHID(); 650 650 $new_value = $xaction->getNewValue(); 651 651 if ($old_value === $new_value) { 652 - continue; 652 + break; 653 653 } 654 654 655 655 // When a task is reassigned, move the old owner to the subscriber