@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Allow packages to be added as revision reviewers via the UI
Summary:
Ref T10939. This lets you add packages as reviewers manually.
"Project Reviewers" now lists both projects and packages. I have renamed this to "Coalition Reviewers" but that's probably horrible and confusing. I'm not sure "Group Reviewers" is much better.
Test Plan:
- Added a package as a reviewer manually.
- Joined it, got authority over it.
- Saw the review on my dashboard.
- Accepted the revision, got authority extended to the package review.
{F1311652}
{F1311653}
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T10939
Differential Revision: https://secure.phabricator.com/D15914
+2
-2
+1
-1
src/applications/differential/customfield/DifferentialProjectReviewersField.php
+1
-1
src/applications/differential/customfield/DifferentialProjectReviewersField.php
+1
-1
src/applications/differential/customfield/DifferentialReviewersField.php
+1
-1
src/applications/differential/customfield/DifferentialReviewersField.php
···
71
71
return id(new AphrontFormTokenizerControl())
72
72
->setUser($this->getViewer())
73
73
->setName($this->getFieldKey())
74
-
->setDatasource(new PhabricatorProjectOrUserDatasource())
74
+
->setDatasource(new DiffusionAuditorDatasource())
75
75
->setValue($phids)
76
76
->setError($this->getFieldError())
77
77
->setLabel($this->getFieldName());