@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Don't render anything on project homepages if there are no properties at all
Summary: Ref T10054.
Test Plan:
{F1068420}
Also looked at a project which did have stuff to make sure the stuff still worked.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T10054
Differential Revision: https://secure.phabricator.com/D15102
+15
+5
src/applications/project/controller/PhabricatorProjectProfileController.php
+5
src/applications/project/controller/PhabricatorProjectProfileController.php
···
31
31
}
32
32
33
33
$properties = $this->buildPropertyListView($project);
34
+
34
35
$watch_action = $this->renderWatchAction($project);
35
36
$header->addActionLink($watch_action);
36
37
···
118
119
$project,
119
120
PhabricatorCustomField::ROLE_VIEW);
120
121
$field_list->appendFieldsToPropertyList($project, $viewer, $view);
122
+
123
+
if ($view->isEmpty()) {
124
+
return null;
125
+
}
121
126
122
127
$view = id(new PHUIBoxView())
123
128
->setColor(PHUIBoxView::GREY)
+10
src/view/phui/PHUIPropertyListView.php
+10
src/view/phui/PHUIPropertyListView.php
···
115
115
$this->invokedWillRenderEvent = true;
116
116
}
117
117
118
+
public function isEmpty() {
119
+
$this->invokeWillRenderEvent();
120
+
121
+
if ($this->parts) {
122
+
return false;
123
+
}
124
+
125
+
return true;
126
+
}
127
+
118
128
public function render() {
119
129
$this->invokeWillRenderEvent();
120
130