@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix dark mode for Differential Revision size indicators
Summary:
Introduce a bunch of variables instead of hardcoding colors.
Refs T15056
Test Plan:
1. Go to http://phorge.localhost/settings/panel/display/ and set `Accessibility` to `Dark Mode (Experimental)`
2. Have some open Revisions in Differential with different sizes, go to http://phorge.localhost/differential/query/all/
Reviewers: O1 Blessed Committers, amybones, mainframe98
Reviewed By: O1 Blessed Committers, amybones, mainframe98
Subscribers: amybones, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Maniphest Tasks: T15056
Differential Revision: https://we.phorge.it/D26197
+14
-4
+5
src/applications/celerity/postprocessor/CelerityDarkModePostprocessor.php
+5
src/applications/celerity/postprocessor/CelerityDarkModePostprocessor.php
···
192
192
'move-background' => '#faca00',
193
193
'copy-background' => '#f1c40f',
194
194
195
+
'diffsize.small.background' => '#324d67',
196
+
'diffsize.large.background' => '#4b3826',
197
+
'diffsize.small.icon' => '#cadce7',
198
+
'diffsize.large.icon' => '#f2d7c0',
199
+
195
200
// Usually light yellow
196
201
'gentle.highlight' => '#26c1c9',
197
202
'gentle.highlight.border' => '#21a9b0',
+5
src/applications/celerity/postprocessor/CelerityDefaultPostprocessor.php
+5
src/applications/celerity/postprocessor/CelerityDefaultPostprocessor.php
···
205
205
'move-background' => '#fdf5d4',
206
206
'copy-background' => '#f1c40f',
207
207
208
+
'diffsize.small.background' => '#f2f7ff',
209
+
'diffsize.large.background' => '#fbede1',
210
+
'diffsize.small.icon' => '#6699ba',
211
+
'diffsize.large.icon' => '#e5ae7e',
212
+
208
213
// Usually light yellow
209
214
'gentle.highlight' => '#fdf3da',
210
215
'gentle.highlight.border' => '#c9b8a8',
+4
-4
webroot/rsrc/css/phui/object-item/phui-oi-list-view.css
+4
-4
webroot/rsrc/css/phui/object-item/phui-oi-list-view.css
···
702
702
}
703
703
704
704
.differential-revision-large {
705
-
background: {$sh-orangebackground};
705
+
background: {$diffsize.large.background};
706
706
}
707
707
708
708
/* NOTE: These are intentionally using nonstandard colors, see T13127. */
709
709
710
710
.differential-revision-large .phui-icon-view {
711
-
color: #e5ae7e;
711
+
color: {$diffsize.large.icon};
712
712
}
713
713
714
714
.differential-revision-small {
715
-
background: #f2f7ff;
715
+
background: {$diffsize.small.background};
716
716
}
717
717
718
718
.differential-revision-small .phui-icon-view {
719
-
color: #6699ba;
719
+
color: {$diffsize.small.icon};
720
720
}
721
721
722
722
.phui-oi-tail {