@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix a bug which could cause imported events to set themselves as their own parents
Summary: Ref T11808. This variable is wrong, and would sometimes cause events to set themsevles as their own parents. They would then fail to load, and disrupt cursor paging.
Test Plan:
- Reproduced T11808 locally by reloading test data 2+ times, creating events with themselves as their own parents.
- Appplied fix.
- Nuked data, reloaded, no more self-parents.
- Test datafile: {F1894017}
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T11808
Differential Revision: https://secure.phabricator.com/D16793
+1
-1
+1
-1
src/applications/calendar/import/PhabricatorCalendarImportEngine.php
+1
-1
src/applications/calendar/import/PhabricatorCalendarImportEngine.php
···
331
331
foreach ($update_map as $full_uid => $event) {
332
332
$parent_uid = $this->getParentNodeUID($node_map[$full_uid]);
333
333
if ($parent_uid) {
334
-
$parent_phid = $update_map[$full_uid]->getPHID();
334
+
$parent_phid = $update_map[$parent_uid]->getPHID();
335
335
} else {
336
336
$parent_phid = null;
337
337
}