@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Discard stdout/stderr from the aphlict subprocess when running in daemon (normal) mode
Summary:
Fixes T11818. We don't discard output, so once we read more than 2GB of output we'll exceed the maximum size of a string in an internal buffer.
Instead, configure the future so output is discarded.
Test Plan: Added logging to `libphutil/`, saw internal buffer grow steadily before this change and stay constant at 0 after this change.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T11818
Differential Revision: https://secure.phabricator.com/D16855
+8
+8
src/applications/aphlict/management/PhabricatorAphlictManagementWorkflow.php
+8
src/applications/aphlict/management/PhabricatorAphlictManagementWorkflow.php
···
416
416
while (true) {
417
417
global $g_future;
418
418
$g_future = new ExecFuture('exec %C', $command);
419
+
420
+
// Discard all output the subprocess produces: it writes to the log on
421
+
// disk, so we don't need to send the output anywhere and can just
422
+
// throw it away.
423
+
$g_future
424
+
->setStdoutSizeLimit(0)
425
+
->setStderrSizeLimit(0);
426
+
419
427
$g_future->resolve();
420
428
421
429
// If the server exited, wait a couple of seconds and restart it.