recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fail more gracefully when rendering transcripts if handle is missing

Summary: Fixes T4628. I can only partially reproduce the root cause here, but if transcript display rules aren't quite right we should just degrade here rather than fatalling. Transcripts are a messy business by any measure.

Test Plan: Sort-of-reproing transcript renders OK now.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T4628

Differential Revision: https://secure.phabricator.com/D8554

epriestley 7167a729 aea62411

+3 -1
+3 -1
src/applications/herald/controller/HeraldTranscriptController.php
··· 297 297 default: 298 298 if ($target) { 299 299 foreach ($target as $k => $phid) { 300 - $target[$k] = $handles[$phid]->getName(); 300 + if (isset($handles[$phid])) { 301 + $target[$k] = $handles[$phid]->getName(); 302 + } 301 303 } 302 304 $target = implode("\n", $target); 303 305 } else {