@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove unused keyboard shortcuts code
Summary:
`PHUIPropertyListView` defines `setHasKeyboardShortcuts()` using `AphrontKeyboardShortcutsAvailableView` setting the CSS class `keyboard-shortcuts-available` defined in `phui-property-list-view.css` and `phui-property-list-view.css`, the latter being the only consumer of the icon `key_question.png`.
Searching the codebase for `asKeyboardShortcuts` there are zero callers as `src/applications/differential/view/DifferentialRevisionDetailView.php` got deleted in https://we.phorge.it/rP148a50e48be146b88036032d1cad772d2627da28. Thus remove that unused code/files.
Note that this is unrelated to `setEnableKeyboardShortcuts()` in `PHUIPagerView`.
Test Plan: Grep the codebase for `asKeyboardShortcuts`
Reviewers: O1 Blessed Committers, mainframe98
Reviewed By: O1 Blessed Committers, mainframe98
Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Differential Revision: https://we.phorge.it/D26005
+6
-61
+5
-6
resources/celerity/map.php
+5
-6
resources/celerity/map.php
···
9
9
'names' => array(
10
10
'conpherence.pkg.css' => '79a197f6',
11
11
'conpherence.pkg.js' => '020aebcf',
12
-
'core.pkg.css' => '578670e1',
12
+
'core.pkg.css' => 'ed73eb65',
13
13
'core.pkg.js' => '086da722',
14
14
'dark-console.pkg.js' => '187792c2',
15
15
'differential.pkg.css' => 'db7c5008',
···
166
166
'rsrc/css/phui/phui-pager.css' => 'd022c7ad',
167
167
'rsrc/css/phui/phui-pinboard-view.css' => '1f08f5d8',
168
168
'rsrc/css/phui/phui-policy-section-view.css' => '139fdc64',
169
-
'rsrc/css/phui/phui-property-list-view.css' => '9a155095',
169
+
'rsrc/css/phui/phui-property-list-view.css' => '3415f8c4',
170
170
'rsrc/css/phui/phui-remarkup-preview.css' => '3c0e5e4f',
171
171
'rsrc/css/phui/phui-segment-bar-view.css' => '5166b370',
172
172
'rsrc/css/phui/phui-spacing.css' => 'b05cadc3',
173
173
'rsrc/css/phui/phui-status.css' => '293b5dad',
174
174
'rsrc/css/phui/phui-tag-view.css' => '8613be82',
175
175
'rsrc/css/phui/phui-timeline-view.css' => 'd349cf47',
176
-
'rsrc/css/phui/phui-two-column-view.css' => 'f96d319f',
176
+
'rsrc/css/phui/phui-two-column-view.css' => '54fb9794',
177
177
'rsrc/css/phui/workboards/phui-workboard-color.css' => '3a1c21ff',
178
178
'rsrc/css/phui/workboards/phui-workboard.css' => 'e7ba21a7',
179
179
'rsrc/css/phui/workboards/phui-workcard.css' => '62056e3b',
···
292
292
'rsrc/image/icon/fatcow/flag_purple.png' => 'c4f423a4',
293
293
'rsrc/image/icon/fatcow/flag_red.png' => '9e6d8817',
294
294
'rsrc/image/icon/fatcow/flag_yellow.png' => '906733f4',
295
-
'rsrc/image/icon/fatcow/key_question.png' => 'c10c26db',
296
295
'rsrc/image/icon/subscribe.png' => '07ef454e',
297
296
'rsrc/image/icon/tango/attachment.png' => 'bac9032d',
298
297
'rsrc/image/icon/tango/edit.png' => 'e6296206',
···
849
848
'phui-pager-css' => 'd022c7ad',
850
849
'phui-pinboard-view-css' => '1f08f5d8',
851
850
'phui-policy-section-view-css' => '139fdc64',
852
-
'phui-property-list-view-css' => '9a155095',
851
+
'phui-property-list-view-css' => '3415f8c4',
853
852
'phui-remarkup-preview-css' => '3c0e5e4f',
854
853
'phui-segment-bar-view-css' => '5166b370',
855
854
'phui-spacing-css' => 'b05cadc3',
···
857
856
'phui-tag-view-css' => '8613be82',
858
857
'phui-theme-css' => '35883b37',
859
858
'phui-timeline-view-css' => 'd349cf47',
860
-
'phui-two-column-view-css' => 'f96d319f',
859
+
'phui-two-column-view-css' => '54fb9794',
861
860
'phui-workboard-color-css' => '3a1c21ff',
862
861
'phui-workboard-view-css' => 'e7ba21a7',
863
862
'phui-workcard-view-css' => '62056e3b',
-2
src/__phutil_library_map__.php
-2
src/__phutil_library_map__.php
···
242
242
'AphrontJSONHTTPParameterType' => 'aphront/httpparametertype/AphrontJSONHTTPParameterType.php',
243
243
'AphrontJSONResponse' => 'aphront/response/AphrontJSONResponse.php',
244
244
'AphrontJavelinView' => 'view/AphrontJavelinView.php',
245
-
'AphrontKeyboardShortcutsAvailableView' => 'view/widget/AphrontKeyboardShortcutsAvailableView.php',
246
245
'AphrontListFilterView' => 'view/layout/AphrontListFilterView.php',
247
246
'AphrontListHTTPParameterType' => 'aphront/httpparametertype/AphrontListHTTPParameterType.php',
248
247
'AphrontLockTimeoutQueryException' => 'infrastructure/storage/exception/AphrontLockTimeoutQueryException.php',
···
6252
6251
'AphrontJSONHTTPParameterType' => 'AphrontHTTPParameterType',
6253
6252
'AphrontJSONResponse' => 'AphrontResponse',
6254
6253
'AphrontJavelinView' => 'AphrontView',
6255
-
'AphrontKeyboardShortcutsAvailableView' => 'AphrontView',
6256
6254
'AphrontListFilterView' => 'AphrontView',
6257
6255
'AphrontListHTTPParameterType' => 'AphrontHTTPParameterType',
6258
6256
'AphrontLockTimeoutQueryException' => 'AphrontRecoverableQueryException',
+1
-12
src/view/phui/PHUIPropertyListView.php
+1
-12
src/view/phui/PHUIPropertyListView.php
···
3
3
final class PHUIPropertyListView extends AphrontView {
4
4
5
5
private $parts = array();
6
-
private $hasKeyboardShortcuts;
7
6
private $object;
8
7
private $invokedWillRenderEvent;
9
8
private $actionList = null;
···
38
37
39
38
public function addClass($class) {
40
39
$this->classes[] = $class;
41
-
return $this;
42
-
}
43
-
44
-
public function setHasKeyboardShortcuts($has_keyboard_shortcuts) {
45
-
$this->hasKeyboardShortcuts = $has_keyboard_shortcuts;
46
40
return $this;
47
41
}
48
42
···
223
217
),
224
218
$items);
225
219
226
-
$shortcuts = null;
227
-
if ($this->hasKeyboardShortcuts) {
228
-
$shortcuts = new AphrontKeyboardShortcutsAvailableView();
229
-
}
230
-
231
220
$list = phutil_tag(
232
221
'div',
233
222
array(
234
223
'class' => 'phui-property-list-properties-wrap '.$stacked,
235
224
),
236
-
array($shortcuts, $list));
225
+
array($list));
237
226
238
227
$action_list = null;
239
228
if ($this->actionList) {
-16
src/view/widget/AphrontKeyboardShortcutsAvailableView.php
-16
src/view/widget/AphrontKeyboardShortcutsAvailableView.php
···
1
-
<?php
2
-
3
-
final class AphrontKeyboardShortcutsAvailableView extends AphrontView {
4
-
5
-
public function render() {
6
-
return phutil_tag(
7
-
'div',
8
-
array(
9
-
'class' => 'keyboard-shortcuts-available',
10
-
),
11
-
pht(
12
-
'Press %s to show keyboard shortcuts.',
13
-
phutil_tag('strong', array(), '?')));
14
-
}
15
-
16
-
}
-17
webroot/rsrc/css/phui/phui-property-list-view.css
-17
webroot/rsrc/css/phui/phui-property-list-view.css
···
2
2
* @provides phui-property-list-view-css
3
3
*/
4
4
5
-
.phui-property-list-view .keyboard-shortcuts-available {
6
-
float: right;
7
-
height: 16px;
8
-
margin: 12px 10px -28px 0px;
9
-
padding: 0px 20px 0px 0px;
10
-
vertical-align: middle;
11
-
color: {$greytext};
12
-
text-align: right;
13
-
font-size: {$smallestfontsize};
14
-
background:
15
-
url('/rsrc/image/icon/fatcow/key_question.png') right center no-repeat;
16
-
}
17
-
18
-
.device .keyboard-shortcuts-available {
19
-
display: none;
20
-
}
21
-
22
5
.phui-property-group-noninitial,
23
6
.phui-property-list-section-noninitial {
24
7
border-color: {$thinblueborder};
-5
webroot/rsrc/css/phui/phui-two-column-view.css
-5
webroot/rsrc/css/phui/phui-two-column-view.css
···
188
188
padding: 12px 8px;
189
189
}
190
190
191
-
.phui-two-column-view .phui-property-list-container
192
-
.keyboard-shortcuts-available {
193
-
display: none;
194
-
}
195
-
196
191
.device .phui-two-column-content .phui-two-column-properties.phui-object-box {
197
192
padding: 0 12px;
198
193
}
-3
webroot/rsrc/image/icon/fatcow/README
-3
webroot/rsrc/image/icon/fatcow/README
webroot/rsrc/image/icon/fatcow/key_question.png
webroot/rsrc/image/icon/fatcow/key_question.png
This is a binary file and will not be displayed.