recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix daemon auth issue

Summary: I touched this code recently but it needs an unusual special case because we call through with the "omnipotent user" from the daemons. As per the TODO below, this will all get cleaned up at some point.

Test Plan: Will make @poop verify.

Reviewers: btrahan, poop

Reviewed By: poop

CC: poop, aran

Differential Revision: https://secure.phabricator.com/D7356

epriestley 7180199d 7e815a06

+3 -2
+2 -1
src/applications/conduit/call/ConduitCall.php
··· 87 87 $this->request->setUser($user); 88 88 89 89 if ($this->shouldRequireAuthentication()) { 90 - if (!$user->isLoggedIn()) { 90 + // TODO: As per below, this should get centralized and cleaned up. 91 + if (!$user->isLoggedIn() && !$user->isOmnipotent()) { 91 92 throw new ConduitException("ERR-INVALID-AUTH"); 92 93 } 93 94
+1 -1
src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
··· 54 54 'corpus' => $message, 55 55 'partial' => true, 56 56 )); 57 - $call->setUser($user); 57 + $call->setUser(PhabricatorUser::getOmnipotentUser()); 58 58 $result = $call->execute(); 59 59 60 60 $field_values = $result['fields'];