recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

T5423, "is newly created" herald rule fails on dry runs

Summary: Fixes T5423, "is newly created" herald rule fails on dry runs

Test Plan: Create herald "is newly created" rule, and do a dry run on an existing pholio mock, differential commit, or maniphest task. Should not return an exception.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T5423

Differential Revision: https://secure.phabricator.com/D10187

authored by

lkassianik and committed by
epriestley 7204f9fe c6998207

+2
+2
src/applications/herald/controller/HeraldTestConsoleController.php
··· 51 51 throw new Exception('Can not build adapter for object!'); 52 52 } 53 53 54 + $adapter->setIsNewObject(false); 55 + 54 56 $rules = id(new HeraldRuleQuery()) 55 57 ->setViewer($user) 56 58 ->withContentTypes(array($adapter->getAdapterContentType()))