+2

src/__phutil_library_map__.php

reviewed

··· 2153 2153 'PhabricatorBoardLayoutEngine' => 'applications/project/engine/PhabricatorBoardLayoutEngine.php', 2154 2154 'PhabricatorBoardRenderingEngine' => 'applications/project/engine/PhabricatorBoardRenderingEngine.php', 2155 2155 'PhabricatorBoardResponseEngine' => 'applications/project/engine/PhabricatorBoardResponseEngine.php', 2156 2156 + 'PhabricatorBoolConfigType' => 'applications/config/type/PhabricatorBoolConfigType.php', 2156 2157 'PhabricatorBoolEditField' => 'applications/transactions/editfield/PhabricatorBoolEditField.php', 2157 2158 'PhabricatorBritishEnglishTranslation' => 'infrastructure/internationalization/translation/PhabricatorBritishEnglishTranslation.php', 2158 2159 'PhabricatorBuiltinDraftEngine' => 'applications/transactions/draft/PhabricatorBuiltinDraftEngine.php', ··· 7356 7357 'PhabricatorBoardLayoutEngine' => 'Phobject', 7357 7358 'PhabricatorBoardRenderingEngine' => 'Phobject', 7358 7359 'PhabricatorBoardResponseEngine' => 'Phobject', 7360 7360 + 'PhabricatorBoolConfigType' => 'PhabricatorTextConfigType', 7359 7361 'PhabricatorBoolEditField' => 'PhabricatorEditField', 7360 7362 'PhabricatorBritishEnglishTranslation' => 'PhutilTranslation', 7361 7363 'PhabricatorBuiltinDraftEngine' => 'PhabricatorDraftEngine',

-25

src/applications/config/controller/PhabricatorConfigEditController.php

reviewed

··· 350 350 case 'set': 351 351 $set_value = array_fill_keys($request->getStrList('value'), true); 352 352 break; 353 353 - case 'bool': 354 354 - switch ($value) { 355 355 - case 'true': 356 356 - $set_value = true; 357 357 - break; 358 358 - case 'false': 359 359 - $set_value = false; 360 360 - break; 361 361 - default: 362 362 - $e_value = pht('Invalid'); 363 363 - $errors[] = pht('Value must be boolean, "true" or "false".'); 364 364 - break; 365 365 - } 366 366 - break; 367 353 case 'class': 368 354 if (!class_exists($value)) { 369 355 $e_value = pht('Invalid'); ··· 425 411 switch ($type) { 426 412 case 'class': 427 413 return $value; 428 428 - case 'bool': 429 429 - return $value ? 'true' : 'false'; 430 414 case 'set': 431 415 return implode("\n", nonempty(array_keys($value), array())); 432 416 default: ··· 456 440 } else { 457 441 $type = $option->getType(); 458 442 switch ($type) { 459 459 - case 'bool': 460 460 - $control = id(new AphrontFormSelectControl()) 461 461 - ->setOptions( 462 462 - array( 463 463 - '' => pht('(Use Default)'), 464 464 - 'true' => idx($option->getBoolOptions(), 0), 465 465 - 'false' => idx($option->getBoolOptions(), 1), 466 466 - )); 467 467 - break; 468 443 case 'class': 469 444 $symbols = id(new PhutilSymbolLoader()) 470 445 ->setType('class')

-15

src/applications/config/management/PhabricatorConfigManagementSetWorkflow.php

reviewed

··· 75 75 case 'class': 76 76 $value = (string)$value; 77 77 break; 78 78 - case 'bool': 79 79 - if ($value == 'true') { 80 80 - $value = true; 81 81 - } else if ($value == 'false') { 82 82 - $value = false; 83 83 - } else { 84 84 - throw new PhutilArgumentUsageException( 85 85 - pht( 86 86 - "Config key '%s' is of type '%s'. Specify '%s' or '%s'.", 87 87 - $key, 88 88 - $type, 89 89 - 'true', 90 90 - 'false')); 91 91 - } 92 92 - break; 93 78 default: 94 79 $value = json_decode($value, true); 95 80 if (!is_array($value)) {

-9

src/applications/config/option/PhabricatorApplicationConfigOptions.php

reviewed

··· 43 43 } 44 44 45 45 switch ($option->getType()) { 46 46 - case 'bool': 47 47 - if ($value !== true && 48 48 - $value !== false) { 49 49 - throw new PhabricatorConfigValidationException( 50 50 - pht( 51 51 - "Option '%s' is of type bool, but value is not true or false.", 52 52 - $option->getKey())); 53 53 - } 54 54 - break; 55 46 case 'class': 56 47 $symbols = id(new PhutilSymbolLoader()) 57 48 ->setType('class')

+62

src/applications/config/type/PhabricatorBoolConfigType.php

reviewed

··· 1 1 + <?php 2 2 + 3 3 + final class PhabricatorBoolConfigType 4 4 + extends PhabricatorTextConfigType { 5 5 + 6 6 + const TYPEKEY = 'bool'; 7 7 + 8 8 + protected function newCanonicalValue( 9 9 + PhabricatorConfigOption $option, 10 10 + $value) { 11 11 + 12 12 + if (!preg_match('/^(true|false)\z/', $value)) { 13 13 + throw $this->newException( 14 14 + pht( 15 15 + 'Value for option "%s" of type "%s" must be either '. 16 16 + '"true" or "false".', 17 17 + $option->getKey(), 18 18 + $this->getTypeKey())); 19 19 + } 20 20 + 21 21 + return ($value === 'true'); 22 22 + } 23 23 + 24 24 + public function newDisplayValue( 25 25 + PhabricatorConfigOption $option, 26 26 + $value) { 27 27 + 28 28 + if ($value) { 29 29 + return 'true'; 30 30 + } else { 31 31 + return 'false'; 32 32 + } 33 33 + } 34 34 + 35 35 + public function validateStoredValue( 36 36 + PhabricatorConfigOption $option, 37 37 + $value) { 38 38 + 39 39 + if (!is_bool($value)) { 40 40 + throw $this->newException( 41 41 + pht( 42 42 + 'Option "%s" is of type "%s", but the configured value is not '. 43 43 + 'a boolean.', 44 44 + $option->getKey(), 45 45 + $this->getTypeKey())); 46 46 + } 47 47 + } 48 48 + 49 49 + protected function newControl(PhabricatorConfigOption $option) { 50 50 + $bool_map = $option->getBoolOptions(); 51 51 + 52 52 + $map = array( 53 53 + '' => pht('(Use Default)'), 54 54 + ) + array( 55 55 + 'true' => idx($bool_map, 0), 56 56 + 'false' => idx($bool_map, 1), 57 57 + ); 58 58 + 59 59 + return id(new AphrontFormSelectControl()) 60 60 + ->setOptions($map); 61 61 + } 62 62 + }