@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Pull only existing authorPHIDs in blame
Summary:
I've hit this error by exhausting memory limit on blaming a big file with lots of unknown authors.
It triggered the error ~1000 times with stack trace containing the whole ~100 kB file.
The memory ran out when it tried to JSON serialize the stack traces for the DarkConsole.
Test Plan: Blamed file with unknown authors.
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D5730
+3
-1
+3
-1
src/applications/diffusion/controller/DiffusionBrowseFileController.php
+3
-1
src/applications/diffusion/controller/DiffusionBrowseFileController.php
···
432
432
$epoch_min = min($epoch_list);
433
433
$epoch_max = max($epoch_list);
434
434
$epoch_range = ($epoch_max - $epoch_min) + 1;
435
-
$handles = $this->loadViewerHandles(ipull($blame_dict, 'authorPHID'));
435
+
436
+
$author_phids = ipull(ifilter($blame_dict, 'authorPHID'), 'authorPHID');
437
+
$handles = $this->loadViewerHandles($author_phids);
436
438
}
437
439
438
440
$line_arr = array();