@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Truncate Conduit 'clientDescription' so we don't overflow the column
Summary: We store the `arc` commandline in this 255-character column, but it can be more than 255-characters long. If it's huge, truncate it.
Test Plan:
Executed:
arc list --conduit-uri=http://local.aphront.com:8080/ --conduit-version 6.aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
Works fine after this patch.
Reviewers: btrahan
Reviewed By: btrahan
CC: aran
Differential Revision: https://secure.phabricator.com/D8327
+3
+3
src/applications/conduit/method/ConduitAPI_conduit_connect_Method.php
+3
src/applications/conduit/method/ConduitAPI_conduit_connect_Method.php
···
61
61
$client = $request->getValue('client');
62
62
$client_version = (int)$request->getValue('clientVersion');
63
63
$client_description = (string)$request->getValue('clientDescription');
64
+
// TODO: This should be character-oriented, not display-oriented.
65
+
// See T3307.
66
+
$client_description = phutil_utf8_shorten($client_description, 255);
64
67
$username = (string)$request->getValue('user');
65
68
66
69
// Log the connection, regardless of the outcome of checks below.