recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Narrowly fix web UI fatal for "almanac.service.edit" Conduit API method

Summary:
See T13120. See T12414. See PHI145. See PHI473. Almanac services require a type before they can do anything, and EditEngine currently builds one with no type. We then fatal when trying to do mundane things like generate documentation.

Instead, build a generic but complete Service for documentation generation in the web UI. This is similar to the previous Drydock Blueprint change from D18849 (or some earlier diff in that series).

(You still probably can't use this method to //create// a service; I'll fix that in the next change.)

Test Plan:
- Viewed "almanac.service.edit" in the web UI.
- Before: immediate fatal ("No Almanac service type "" exists!").
- After: Page works. No claims about the method doing anything useful.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D19315

epriestley 72ab8640 472bc3d9

+6
+6
src/applications/almanac/editor/AlmanacServiceEditEngine.php
··· 41 41 return AlmanacService::initializeNewService($service_type); 42 42 } 43 43 44 + protected function newEditableObjectForDocumentation() { 45 + $service_type = new AlmanacCustomServiceType(); 46 + $this->setServiceType($service_type->getServiceTypeConstant()); 47 + return $this->newEditableObject(); 48 + } 49 + 44 50 protected function newObjectQuery() { 45 51 return new AlmanacServiceQuery(); 46 52 }