@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Various minor JSHint fixes.
Summary: Various fixes as suggested by JSHint.
Test Plan: Eye-balled it.
Reviewers: #blessed_reviewers, epriestley
Reviewed By: #blessed_reviewers, epriestley
Subscribers: epriestley, Korvin
Differential Revision: https://secure.phabricator.com/D9783
+12
-14
+2
-4
support/aphlict/server/aphlict_server.js
+2
-4
support/aphlict/server/aphlict_server.js
···
62
62
63
63
var net = require('net');
64
64
var http = require('http');
65
-
var url = require('url');
66
65
67
66
process.on('uncaughtException', function(err) {
68
-
debug.log("\n<<< UNCAUGHT EXCEPTION! >>>\n" + err.stack);
67
+
debug.log('\n<<< UNCAUGHT EXCEPTION! >>>\n' + err.stack);
69
68
70
69
process.exit(1);
71
70
});
···
188
187
}
189
188
});
190
189
} else if (request.url == '/status/') {
191
-
request.on('data', function(data) {
190
+
request.on('data', function() {
192
191
// We just ignore the request data, but newer versions of Node don't
193
192
// get to 'end' if we don't process the data. See T2953.
194
193
});
···
213
212
response.write('400 Bad Request');
214
213
response.end();
215
214
}
216
-
217
215
}).listen(config.admin, config.host);
218
216
219
217
function transmit(msg) {
+2
-2
support/aphlict/server/lib/AphlictFlashPolicyServer.js
+2
-2
support/aphlict/server/lib/AphlictFlashPolicyServer.js
···
46
46
this._log('<FlashPolicy> Socket Error: %s', error);
47
47
},
48
48
49
-
_log: function(pattern) {
49
+
_log: function() {
50
50
this._debug && this._debug.log.apply(this._debug, arguments);
51
51
},
52
52
···
60
60
'</cross-domain-policy>'
61
61
];
62
62
63
-
return policy.join("\n") + "\0";
63
+
return policy.join('\n') + '\0';
64
64
}
65
65
66
66
}
+2
-2
support/aphlict/server/lib/AphlictLog.js
+2
-2
support/aphlict/server/lib/AphlictLog.js
···
32
32
return this;
33
33
},
34
34
35
-
log: function(pattern) {
35
+
log: function() {
36
36
var str = util.format.apply(null, arguments);
37
37
var date = new Date().toLocaleString();
38
38
str = '[' + date + '] ' + str;
···
43
43
}
44
44
45
45
for (ii = 0; ii < this._writeToLogs.length; ii++) {
46
-
this._writeToLogs[ii].write(str + "\n");
46
+
this._writeToLogs[ii].write(str + '\n');
47
47
}
48
48
}
49
49
+2
-2
webroot/rsrc/js/application/differential/behavior-comment-jump.js
+2
-2
webroot/rsrc/js/application/differential/behavior-comment-jump.js
···
7
7
8
8
JX.behavior('differential-comment-jump', function() {
9
9
function handle_jump(offset) {
10
-
return (function(e) {
10
+
return function(e) {
11
11
var parent = JX.$('differential-review-stage');
12
12
var clicked = e.getNode('differential-inline-comment');
13
13
var inlines = JX.DOM.scry(parent, 'div', 'differential-inline-comment');
···
24
24
});
25
25
JX.DOM.scrollTo(jumpto);
26
26
e.kill();
27
-
});
27
+
};
28
28
}
29
29
30
30
JX.Stratcom.listen('click', 'differential-inline-prev', handle_jump(-1));
+4
-4
webroot/rsrc/js/core/behavior-phabricator-remarkup-assist.js
+4
-4
webroot/rsrc/js/core/behavior-phabricator-remarkup-assist.js
···
131
131
break;
132
132
case 'fa-code':
133
133
sel = sel || 'foreach ($list as $item) {\n work_miracles($item);\n}';
134
-
var prefix = (r.start === 0) ? '' : '\n';
135
-
update(area, prefix + '```\n', sel, '\n```');
134
+
var code_prefix = (r.start === 0) ? '' : '\n';
135
+
update(area, code_prefix + '```\n', sel, '\n```');
136
136
break;
137
137
case 'fa-table':
138
-
var prefix = (r.start === 0 ? '' : '\n\n');
139
-
update(area, prefix + '| ', sel || pht('data'), ' |');
138
+
var table_prefix = (r.start === 0 ? '' : '\n\n');
139
+
update(area, table_prefix + '| ', sel || pht('data'), ' |');
140
140
break;
141
141
case 'fa-meh-o':
142
142
new JX.Workflow('/macro/meme/create/')