@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Skip "null" lines when constructing raw documents for DocumentEngine rendering
Summary: See <https://discourse.phabricator-community.org/t/more-exceptions-when-viewing-diffs/3789>. This is a similar issue with the same datastructure.
Test Plan: Works correctly under PHP 7.3, but this may not be the end of things.
Differential Revision: https://secure.phabricator.com/D21171
+5
-1
+5
-1
src/applications/differential/parser/DifferentialChangesetParser.php
+5
-1
src/applications/differential/parser/DifferentialChangesetParser.php
···
1901
1901
$text = array();
1902
1902
1903
1903
foreach ($lines as $line) {
1904
+
if ($line === null) {
1905
+
continue;
1906
+
}
1907
+
1904
1908
// If this is a "No newline at end of file." annotation, don't hand it
1905
1909
// off to the DocumentEngine.
1906
-
if ($line['type'] == '\\') {
1910
+
if ($line['type'] === '\\') {
1907
1911
continue;
1908
1912
}
1909
1913