recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix a possible `count(null)` in DifferentialRevisionActionTransaction

Summary:
This change prevents the following error when using PHP 7.2:

```
ERROR 2: count(): Parameter must be an array or an object that implements Countable at [/usr/local/lib/php/phabricator/src/applications/differential/xaction/DifferentialRevisionActionTransaction.php:132]
```

A similar issue was fixed in D18964

Test Plan: Tested in a live system.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D19242

authored by

Tino Breddin and committed by
epriestley 73b68bc2 3bf8d568

+1 -1
+1 -1
src/applications/differential/xaction/DifferentialRevisionActionTransaction.php
··· 80 80 DifferentialRevision $revision) { 81 81 return array( 82 82 array(), 83 - null, 83 + array(), 84 84 ); 85 85 } 86 86