@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Improve `bin/config set` errors for complex values
Summary:
- Fix missing space before "For example:".
- Fix instruction to run `bin/config set value` instead of `bin/config set key value`.
- Minor cleanup.
Test Plan: Tried to set `files.image-mime-types`, `load-libraries`.
Reviewers: chad
Reviewed By: chad
Differential Revision: https://secure.phabricator.com/D14080
+24
-14
+3
-3
resources/celerity/map.php
+3
-3
resources/celerity/map.php
···
7
7
*/
8
8
return array(
9
9
'names' => array(
10
-
'core.pkg.css' => 'e9f745e2',
10
+
'core.pkg.css' => '3fcfaed8',
11
11
'core.pkg.js' => '47dc9ebb',
12
12
'darkconsole.pkg.js' => 'e7393ebb',
13
13
'differential.pkg.css' => '2de124c9',
···
104
104
'rsrc/css/application/tokens/tokens.css' => '3d0f239e',
105
105
'rsrc/css/application/uiexample/example.css' => '528b19de',
106
106
'rsrc/css/core/core.css' => 'a76cefc9',
107
-
'rsrc/css/core/remarkup.css' => 'ef286a6e',
107
+
'rsrc/css/core/remarkup.css' => '1c4ac273',
108
108
'rsrc/css/core/syntax.css' => '9fd11da8',
109
109
'rsrc/css/core/z-index.css' => '57ddcaa2',
110
110
'rsrc/css/diviner/diviner-shared.css' => '5a337049',
···
737
737
'phabricator-object-selector-css' => '85ee8ce6',
738
738
'phabricator-phtize' => 'd254d646',
739
739
'phabricator-prefab' => '6920d200',
740
-
'phabricator-remarkup-css' => 'ef286a6e',
740
+
'phabricator-remarkup-css' => '1c4ac273',
741
741
'phabricator-search-results-css' => '7dea472c',
742
742
'phabricator-shaped-request' => '7cbe244b',
743
743
'phabricator-side-menu-view-css' => 'bec2458e',
+21
-11
src/applications/config/management/PhabricatorConfigManagementSetWorkflow.php
+21
-11
src/applications/config/management/PhabricatorConfigManagementSetWorkflow.php
···
96
96
if (!is_array($value)) {
97
97
switch ($type) {
98
98
case 'set':
99
+
$command = csprintf(
100
+
'./bin/config set %R %s',
101
+
$key,
102
+
'{"value1": true, "value2": true}');
103
+
99
104
$message = sprintf(
100
-
"%s%s\n\n %s\n",
101
-
pht(
102
-
"Config key '%s' is of type '%s'. Specify it in JSON.",
103
-
$key,
104
-
$type),
105
-
pht('For example:'),
106
-
'./bin/config set \'{"value1": true, "value2": true}\'');
105
+
"%s\n\n %s\n",
106
+
pht(
107
+
'Config key "%s" is of type "%s". Specify it in JSON. '.
108
+
'For example:',
109
+
$key,
110
+
$type),
111
+
$command);
107
112
break;
108
113
default:
109
114
if (preg_match('/^list</', $type)) {
115
+
$command = csprintf(
116
+
'./bin/config set %R %s',
117
+
$key,
118
+
'["a", "b", "c"]');
119
+
110
120
$message = sprintf(
111
-
"%s%s\n\n %s\n",
121
+
"%s\n\n %s\n",
112
122
pht(
113
-
"Config key '%s' is of type '%s'. Specify it in JSON.",
123
+
'Config key "%s" is of type "%s". Specify it in JSON. '.
124
+
'For example:',
114
125
$key,
115
126
$type),
116
-
pht('For example:'),
117
-
'./bin/config set \'["a", "b", "c"]\'');
127
+
$command);
118
128
} else {
119
129
$message = pht(
120
130
'Config key "%s" is of type "%s". Specify it in JSON.',