recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Make Application->isInstalled canonical

Summary: We currently inspect `phabricator.uninstalled-applications` in two places -- when building a list of `getAllInstalledApplications()` and when asking an application if it `isInstalled()`. This diff moves that all to the latter function, meaning we can override it in clever and subtle ways for applications that want to add extra defensiveness about whether they should be considered installed or not (e.g. Releeph, in D4932.)

Test Plan: Load the main Phabricator page, pick an application, uninstall it, notice it is absent, then install it and notice the launch icon reappear.

Reviewers: epriestley, Afaque_Hussain

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5326

Edward Speyer 7487c574 33997d43

+1 -5
+1 -5
src/applications/base/PhabricatorApplication.php
··· 273 273 $show_beta = PhabricatorEnv::getEnvConfig( 274 274 'phabricator.show-beta-applications'); 275 275 276 - $uninstalled = PhabricatorEnv::getEnvConfig( 277 - 'phabricator.uninstalled-applications'); 278 - 279 276 if (empty($applications)) { 280 277 $all_applications = self::getAllApplications(); 281 278 $apps = array(); 282 279 foreach ($all_applications as $app) { 283 - $class = get_class($app); 284 - if (isset($uninstalled[$class])) { 280 + if (!$app->isInstalled()) { 285 281 continue; 286 282 } 287 283