@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Read "Database Status" page connection information from cluster config if present
Summary:
Fixes T11043. This page was still reading the old information directly instead of going through the cluster-aware stuff.
Have it ask the cluster-aware stuff for information instead.
Test Plan:
- Nuked MySQL on localhost.
- Configured cluster hosts.
- Loaded "Database Status" page -- worked after patch.
- Grepped for any remaining `mysql.configuration-provider` stragglers, came up empty.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T11043
Differential Revision: https://secure.phabricator.com/D15982
+5
-7
+5
-7
src/applications/config/controller/PhabricatorConfigDatabaseController.php
+5
-7
src/applications/config/controller/PhabricatorConfigDatabaseController.php
···
4
4
extends PhabricatorConfigController {
5
5
6
6
protected function buildSchemaQuery() {
7
-
$conf = PhabricatorEnv::newObjectFromConfig(
8
-
'mysql.configuration-provider',
9
-
array($dao = null, 'w'));
7
+
$ref = PhabricatorDatabaseRef::getMasterDatabaseRef();
10
8
11
9
$api = id(new PhabricatorStorageManagementAPI())
12
-
->setUser($conf->getUser())
13
-
->setHost($conf->getHost())
14
-
->setPort($conf->getPort())
10
+
->setUser($ref->getUser())
11
+
->setHost($ref->getHost())
12
+
->setPort($ref->getPort())
15
13
->setNamespace(PhabricatorLiskDAO::getDefaultStorageNamespace())
16
-
->setPassword($conf->getPassword());
14
+
->setPassword($ref->getPass());
17
15
18
16
$query = id(new PhabricatorConfigSchemaQuery())
19
17
->setAPI($api);