@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
[Redesign] Cleanup Harbormaster UI
Summary: Ref T8099, adds StatusIcons in place of barColor. May need to revisit icons. Also fixed incorrect icons used in Drydock.
Test Plan: Visit Harbormaster, Drydock, see proper icons.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T8099
Differential Revision: https://secure.phabricator.com/D13054
+15
-13
+2
-2
src/applications/drydock/view/DrydockLeaseListView.php
+2
-2
src/applications/drydock/view/DrydockLeaseListView.php
···
42
42
$item->setEpoch($lease->getDateCreated());
43
43
44
44
if ($lease->isActive()) {
45
-
$item->setStatusIcon('fa-dot-circle green');
45
+
$item->setStatusIcon('fa-dot-circle-o green');
46
46
} else {
47
-
$item->setStatusIcon('fa-dot-circle red');
47
+
$item->setStatusIcon('fa-dot-circle-o red');
48
48
}
49
49
50
50
$view->addItem($item);
+4
-4
src/applications/drydock/view/DrydockResourceListView.php
+4
-4
src/applications/drydock/view/DrydockResourceListView.php
···
27
27
28
28
switch ($resource->getStatus()) {
29
29
case DrydockResourceStatus::STATUS_PENDING:
30
-
$item->setStatusIcon('fa-dot-circle yellow');
30
+
$item->setStatusIcon('fa-dot-circle-o yellow');
31
31
break;
32
32
case DrydockResourceStatus::STATUS_OPEN:
33
-
$item->setStatusIcon('fa-dot-circle green');
33
+
$item->setStatusIcon('fa-dot-circle-o green');
34
34
break;
35
35
case DrydockResourceStatus::STATUS_DESTROYED:
36
-
$item->setStatusIcon('fa-times-circle black');
36
+
$item->setStatusIcon('fa-times-circle-o black');
37
37
break;
38
38
default:
39
-
$item->setStatusIcon('fa-dot-circle red');
39
+
$item->setStatusIcon('fa-dot-circle-o red');
40
40
break;
41
41
}
42
42
+3
-1
src/applications/harbormaster/controller/HarbormasterBuildableViewController.php
+3
-1
src/applications/harbormaster/controller/HarbormasterBuildableViewController.php
···
175
175
->setHref($view_uri);
176
176
177
177
$status = $build->getBuildStatus();
178
-
$item->setBarColor(HarbormasterBuild::getBuildStatusColor($status));
178
+
$item->setStatusIcon(
179
+
'fa-dot-circle-o '.HarbormasterBuild::getBuildStatusColor($status),
180
+
HarbormasterBuild::getBuildStatusName($status));
179
181
180
182
$item->addAttribute(HarbormasterBuild::getBuildStatusName($status));
181
183
+3
-3
src/applications/harbormaster/controller/HarbormasterPlanViewController.php
+3
-3
src/applications/harbormaster/controller/HarbormasterPlanViewController.php
···
122
122
$item = id(new PHUIObjectItemView())
123
123
->setObjectName(pht('Step %d.%d', $depth, $i))
124
124
->setHeader(pht('Unknown Implementation'))
125
-
->setBarColor('red')
125
+
->setStatusIcon('fa-warning red')
126
126
->addAttribute(pht(
127
127
'This step has an invalid implementation (%s).',
128
128
$step->getClassName()))
···
208
208
209
209
if ($has_conflicts) {
210
210
$has_any_conflicts = true;
211
-
$item->setBarColor('red');
211
+
$item->setStatusIcon('fa-warning red');
212
212
}
213
213
214
214
if ($run_ref['cycle']) {
···
216
216
}
217
217
218
218
if ($is_deadlocking) {
219
-
$item->setBarColor('red');
219
+
$item->setStatusIcon('fa-warning red');
220
220
}
221
221
222
222
$step_list->addItem($item);
+3
-3
src/applications/people/controller/PhabricatorPeopleLdapController.php
+3
-3
src/applications/people/controller/PhabricatorPeopleLdapController.php
···
101
101
102
102
$header = pht('Successfully added %s', $username);
103
103
$attribute = null;
104
-
$color = 'green';
104
+
$color = 'fa-check green';
105
105
} catch (Exception $ex) {
106
106
$header = pht('Failed to add %s', $username);
107
107
$attribute = $ex->getMessage();
108
-
$color = 'red';
108
+
$color = 'fa-times red';
109
109
}
110
110
111
111
$item = id(new PHUIObjectItemView())
112
112
->setHeader($header)
113
113
->addAttribute($attribute)
114
-
->setBarColor($color);
114
+
->setStatusIcon($color);
115
115
116
116
$list->addItem($item);
117
117
}