@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Allow admins to edit email addresses of bot accounts

Summary:
e0a3e6ba3b87f96c83905e7188bb6161f7480784 explicitly mentioned
verified bots don't get a panel, but unverified bots are not a thing
(anymore) as the email address provided during creation is automatically
verified.

It's not outside the realm of possibilities that the email address might
need to change later on, so requiring manually editing the database
instead of using existing infrastructure is silly.

Closes T16111

Test Plan:
* As an admin, go to http://phorge.localhost/settings/user/SomeBotUser/, see new item "Email Addresses" in the panel on the left.
* As an admin, go to http://phorge.localhost/settings/user/SomeBotUser/page/email/ directly, don't get a 404 anymore.
* As a non-admin, go to http://phorge.localhost/settings/user/SomeBotUser/page/email/ and get a 404 as before.
* As an admin, on http://phorge.localhost/settings/user/SomeBotUser/page/email/ directly, add a new email address, mark it as primary, be able to remove the old email address. Check the phabricator_user.user_email DB table that the account's email address has been correctly updated.

Reviewers: O1 Blessed Committers, aklapper

Reviewed By: O1 Blessed Committers, aklapper

Subscribers: aklapper, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16111

Differential Revision: https://we.phorge.it/D26090

mainframe98 7584cca1 c57167f2

+3 -1
+3 -1
src/applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php
··· 20 20 } 21 21 22 22 public function isManagementPanel() { 23 - if ($this->getUser()->getIsMailingList()) { 23 + $user = $this->getUser(); 24 + 25 + if ($user->getIsMailingList() || $user->getIsSystemAgent()) { 24 26 return true; 25 27 } 26 28