recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix PHP 8.1 "strlen(null)" warning in XHProf search

Summary: Closes T16339

Test Plan:
* Install the xhprof extension
* Run any arc command with `--xprofile run.json`
* Visit http://phorge.localhost/xhprof/ and upload the xhprof file by drag-and-dropping
* Navigate back to http://phorge.localhost/xhprof/ and see the deprecation in the error log
* Apply this patch and observe it gone

Reviewers: O1 Blessed Committers, aklapper

Reviewed By: O1 Blessed Committers, aklapper

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16339

Differential Revision: https://we.phorge.it/D26497

mainframe98 759aa0f8 6f21c927

+1 -1
+1 -1
src/applications/xhprof/storage/PhabricatorXHProfSample.php
··· 43 43 44 44 public function getDisplayName() { 45 45 $request_path = $this->getRequestPath(); 46 - if (strlen($request_path)) { 46 + if (phutil_nonempty_string($request_path)) { 47 47 return $request_path; 48 48 } 49 49