recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Remove bad "Session" link in User activity logs

Summary:
Fixes T12215. Two issues:

- We build this `$session` link out of `$ip`, which is (a) wrong even if `$ip` was the IP and (b) super wrong since `$ip` is a tag.
- These links don't work even if we'd built them right: searching by the //prefix// of a session identifier does nothing.

At least for now, just get rid of the links rather than trying to make this behavior work.

Test Plan:
On People > Activity logs:

- Before patch: Saw bad links with bogus targets in "session" column.
- After patch: Saw plain text in "session" column.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12215

Differential Revision: https://secure.phabricator.com/D17316

epriestley 75abf799 3d44208e

-6
-6
src/applications/people/view/PhabricatorUserLogView.php
··· 43 43 'href' => $base_uri.'?ip='.$ip.'#R', 44 44 ), 45 45 $ip); 46 - $session = phutil_tag( 47 - 'a', 48 - array( 49 - 'href' => $base_uri.'?sessions='.$ip.'#R', 50 - ), 51 - $session); 52 46 } 53 47 54 48 $action = $log->getAction();