@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
PHPDoc: Make some parameter types match type in signatures
Summary: For explicitly mentioned Phorge class types in the function signature, use the same type in the PHPDoc for the parameter.
Test Plan: Compare classname type in function signature and in PHPDoc; run static code analysis.
Reviewers: O1 Blessed Committers, avivey
Reviewed By: O1 Blessed Committers, avivey
Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Differential Revision: https://we.phorge.it/D25937
+4
-3
+1
-1
src/applications/harbormaster/engine/HarbormasterBuildEngine.php
+1
-1
src/applications/harbormaster/engine/HarbormasterBuildEngine.php
···
437
437
* the overall state of the associated buildable. Compute the new aggregate
438
438
* state and save it on the buildable.
439
439
*
440
-
* @param HarbormasterBuild $buildable The buildable to update.
440
+
* @param HarbormasterBuildable $buildable The buildable to update.
441
441
* @return void
442
442
*/
443
443
public function updateBuildable(HarbormasterBuildable $buildable) {
+2
-1
src/infrastructure/customfield/field/PhabricatorCustomField.php
+2
-1
src/infrastructure/customfield/field/PhabricatorCustomField.php
···
1004
1004
* when a transaction would set a field to an invalid value, or when a field
1005
1005
* is required but no transactions provide value.
1006
1006
*
1007
-
* @param PhabricatorLiskDAO $editor Editor applying the transactions.
1007
+
* @param PhabricatorApplicationTransactionEditor $editor Editor applying the
1008
+
* transactions.
1008
1009
* @param string $type Transaction type. This type is always
1009
1010
* `PhabricatorTransactions::TYPE_CUSTOMFIELD`, it is provided for
1010
1011
* convenience when constructing exceptions.
+1
-1
src/infrastructure/markup/PhabricatorMarkupInterface.php
+1
-1
src/infrastructure/markup/PhabricatorMarkupInterface.php
···
62
62
*
63
63
* @param string $field Field name.
64
64
* @param string $output The finalized output of the engine.
65
-
* @param string $engine The engine which generated the output.
65
+
* @param PhutilMarkupEngine $engine The engine which generated the output.
66
66
* @return string Final output.
67
67
* @task markup
68
68
*/