@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Use PHUIObjectBoxView on Daemons
Summary: Consistent headers.
Test Plan: Reviewed my running daemons
Reviewers: epriestley
Reviewed By: epriestley
CC: Korvin, epriestley, aran
Differential Revision: https://secure.phabricator.com/D8013
+15
-18
+12
-17
src/applications/daemon/controller/PhabricatorDaemonConsoleController.php
+12
-17
src/applications/daemon/controller/PhabricatorDaemonConsoleController.php
···
116
116
'n',
117
117
));
118
118
119
-
$completed_header = id(new PHUIHeaderView())
120
-
->setHeader(pht('Recently Completed Tasks (Last 15m)'));
121
-
122
-
$completed_panel = new AphrontPanelView();
119
+
$completed_panel = new PHUIObjectBoxView();
120
+
$completed_panel->setHeaderText(
121
+
pht('Recently Completed Tasks (Last 15m)'));
123
122
$completed_panel->appendChild($completed_table);
124
-
$completed_panel->setNoBackground();
125
-
126
-
$daemon_header = id(new PHUIHeaderView())
127
-
->setHeader(pht('Active Daemons'));
128
123
129
124
$daemon_table = new PhabricatorDaemonLogListView();
130
125
$daemon_table->setUser($user);
···
150
145
pht('View Task')),
151
146
);
152
147
}
148
+
149
+
$daemon_panel = new PHUIObjectBoxView();
150
+
$daemon_panel->setHeaderText(pht('Active Daemons'));
151
+
$daemon_panel->appendChild($daemon_table);
153
152
154
153
$leased_table = new AphrontTableView($rows);
155
154
$leased_table->setHeaders(
···
172
171
));
173
172
$leased_table->setNoDataString(pht('No tasks are leased by workers.'));
174
173
175
-
$leased_panel = new AphrontPanelView();
176
-
$leased_panel->setHeader('Leased Tasks');
174
+
$leased_panel = new PHUIObjectBoxView();
175
+
$leased_panel->setHeaderText(pht('Leased Tasks'));
177
176
$leased_panel->appendChild($leased_table);
178
-
$leased_panel->setNoBackground();
179
177
180
178
$task_table = new PhabricatorWorkerActiveTask();
181
179
$queued = queryfx_all(
···
205
203
));
206
204
$queued_table->setNoDataString(pht('Task queue is empty.'));
207
205
208
-
$queued_panel = new AphrontPanelView();
209
-
$queued_panel->setHeader(pht('Queued Tasks'));
206
+
$queued_panel = new PHUIObjectBoxView();
207
+
$queued_panel->setHeaderText(pht('Queued Tasks'));
210
208
$queued_panel->appendChild($queued_table);
211
-
$queued_panel->setNoBackground();
212
209
213
210
$crumbs = $this->buildApplicationCrumbs();
214
211
$crumbs->addTextCrumb(pht('Console'));
···
218
215
$nav->appendChild(
219
216
array(
220
217
$crumbs,
221
-
$completed_header,
222
218
$completed_panel,
223
-
$daemon_header,
224
-
$daemon_table,
219
+
$daemon_panel,
225
220
$queued_panel,
226
221
$leased_panel,
227
222
));
+3
-1
src/applications/daemon/view/PhabricatorDaemonLogListView.php
+3
-1
src/applications/daemon/view/PhabricatorDaemonLogListView.php
···
17
17
throw new Exception("Call setUser() before rendering!");
18
18
}
19
19
20
-
$list = id(new PHUIObjectItemListView());
20
+
$list = id(new PHUIObjectItemListView())
21
+
->setCards(true)
22
+
->setFlush(true);
21
23
foreach ($this->daemonLogs as $log) {
22
24
$id = $log->getID();
23
25
$epoch = $log->getDateCreated();