@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Don't trim remarkup corpora before summarizing

Summary:
Currently, lists like this:

```
- a
- b
- c
```

...get trimmed before summarization and end up looking like this after summarization:

```
- a
- b
- c
```

This produces the summary artifacts (first item at wrong indent level):

{F399841}

Instead, don't trim. This produces better summaries.

Test Plan: Saw a better summary of a list.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D12794

+1 -1
+1 -1
src/infrastructure/markup/PhabricatorMarkupEngine.php
··· 586 586 // - Hopefully don't return too much text. We don't explicitly limit 587 587 // this right now. 588 588 589 - $blocks = preg_split("/\n *\n\s*/", trim($corpus)); 589 + $blocks = preg_split("/\n *\n\s*/", $corpus); 590 590 591 591 $best = null; 592 592 foreach ($blocks as $block) {