@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
When a revision is closed, always promote it out of draft
Summary:
Fixes T13300. Currently, if you create a revision and then immediately land it (either using `--draft` or just beating Harbormaster to the punch) it can be stuck in "Draft" forever.
Instead, count landing changes like this as a publishing action.
Test Plan:
- Used `arc diff --hold` to create a revision, then pushed the commit immediately.
- Before change: revision closed, but was stuck in draft.
- After change: revision closed and was promoted out of draft.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T13300
Differential Revision: https://secure.phabricator.com/D20565
+5
+5
src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php
+5
src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php
···
44
44
$object->setProperty(
45
45
DifferentialRevision::PROPERTY_CLOSED_FROM_ACCEPTED,
46
46
$was_accepted);
47
+
48
+
// See T13300. When a revision is closed, we promote it out of "Draft"
49
+
// immediately. This usually happens when a user creates a draft revision
50
+
// and then lands the associated commit before the revision leaves draft.
51
+
$object->setShouldBroadcast(true);
47
52
}
48
53
49
54
protected function validateAction($object, PhabricatorUser $viewer) {