@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix insufficient loading for processing Differential mail
Summary: Some actions (notably, `!accept`) require more information than we currently load.
Test Plan: Piped in some `!accept` mail using `bin/mail receive-test`.
Reviewers: btrahan
Reviewed By: btrahan
Subscribers: epriestley
Differential Revision: https://secure.phabricator.com/D8844
+4
-4
+4
-4
src/applications/differential/mail/DifferentialRevisionMailReceiver.php
+4
-4
src/applications/differential/mail/DifferentialRevisionMailReceiver.php
···
15
15
protected function loadObject($pattern, PhabricatorUser $viewer) {
16
16
$id = (int)trim($pattern, 'D');
17
17
18
-
$results = id(new DifferentialRevisionQuery())
18
+
return id(new DifferentialRevisionQuery())
19
19
->setViewer($viewer)
20
20
->withIDs(array($id))
21
21
->needReviewerStatus(true)
22
-
->execute();
23
-
24
-
return head($results);
22
+
->needReviewerAuthority(true)
23
+
->needActiveDiffs(true)
24
+
->executeOne();
25
25
}
26
26
27
27
protected function processReceivedObjectMail(