@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix conduit result tables on mobile views
Summary: Fixes T8139. These tables don't `setHeaders()`, so we don't correctly default columns to be visible on devices.
Test Plan: Conduit results now visible on devices.
Reviewers: btrahan, chad
Reviewed By: chad
Subscribers: epriestley
Maniphest Tasks: T8139
Differential Revision: https://secure.phabricator.com/D12784
+5
+5
src/view/control/AphrontTableView.php
+5
src/view/control/AphrontTableView.php
···
124
124
125
125
$visibility = array_values($this->columnVisibility);
126
126
$device_visibility = array_values($this->deviceVisibility);
127
+
127
128
$headers = $this->headers;
128
129
$short_headers = $this->shortHeaders;
129
130
$sort_values = $this->sortValues;
···
235
236
if ($data) {
236
237
$row_num = 0;
237
238
foreach ($data as $row) {
239
+
$row_size = count($row);
238
240
while (count($row) > count($col_classes)) {
239
241
$col_classes[] = null;
240
242
}
241
243
while (count($row) > count($visibility)) {
242
244
$visibility[] = true;
245
+
}
246
+
while (count($row) > count($device_visibility)) {
247
+
$device_visibility[] = true;
243
248
}
244
249
$tr = array();
245
250
// NOTE: Use of a separate column counter is to allow this to work