@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Reject objects with invalid policies instead of fataling
Summary: This is correct, but the root cause of the issue isn't very clear to me.
Test Plan: Poked around various pages which filter objects.
Reviewers: joshuaspence
Reviewed By: joshuaspence
Subscribers: epriestley
Differential Revision: https://secure.phabricator.com/D11727
+5
-1
+5
-1
src/applications/policy/filter/PhabricatorPolicyFilter.php
+5
-1
src/applications/policy/filter/PhabricatorPolicyFilter.php
···
411
411
$viewer = $this->viewer;
412
412
$viewer_phid = $viewer->getPHID();
413
413
414
-
$policy = $this->customPolicies[$viewer_phid][$policy_phid];
414
+
$policy = idx($this->customPolicies[$viewer_phid], $policy_phid);
415
+
if (!$policy) {
416
+
// Reject, this policy is bogus.
417
+
return false;
418
+
}
415
419
416
420
$objects = $policy->getRuleObjects();
417
421
$action = null;