recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Remarkup - add underline rule

Summary: we need this for legalese. Ref T3116

Test Plan: made a legalpad document with underlines. also re-gened docs and noted underlines worked

Reviewers: epriestley

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Maniphest Tasks: T3116

Differential Revision: https://secure.phabricator.com/D7996

Bob Trahan 7686efb8 220addb2

+4 -2
+3 -2
src/docs/user/userguide/remarkup.diviner
··· 18 18 19 19 These are inline styles, and can be applied to most text: 20 20 21 - **bold** //italic// ##monospaced## `monospaced` ~~deleted~~ 21 + **bold** //italic// ##monospaced## `monospaced` ~~deleted~~ __underlined__ 22 22 D123 T123 rX123 # Link to Objects 23 23 {D123} {T123} # Link to Objects (Full Name) 24 24 {F123} # Embed Images ··· 58 58 ##monospaced text## 59 59 `monospaced text` 60 60 ~~deleted text~~ 61 + __underlined text__ 61 62 62 63 Those produce **bold text**, //italic text//, ##monospaced text##, 63 - `monospaced text` and ~~deleted text~~, respectively. 64 + `monospaced text`, ~~deleted text~~, and __underlined text__, respectively. 64 65 65 66 = Layout = 66 67
+1
src/infrastructure/markup/PhabricatorMarkupEngine.php
··· 455 455 $rules[] = new PhutilRemarkupRuleBold(); 456 456 $rules[] = new PhutilRemarkupRuleItalic(); 457 457 $rules[] = new PhutilRemarkupRuleDel(); 458 + $rules[] = new PhutilRemarkupRuleUnderline(); 458 459 459 460 foreach (self::loadCustomInlineRules() as $rule) { 460 461 $rules[] = $rule;