@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix "r" and "R" both replying with quote on inline comments

Summary: Ref T13513. The code which added "r" and "R" to the inline menu accidentally discarded the difference between the keystrokes.

Test Plan:
- Clicked an inline, pressed "r", got new empty inline (previously: inline with quote).
- Clicked an inline, pressed "R", got a new quoted inline.
- Repeated steps with the menu items, got the expected behaviors.

Maniphest Tasks: T13513

Differential Revision: https://secure.phabricator.com/D21268

+9 -9
+8 -8
resources/celerity/map.php
··· 13 13 'core.pkg.js' => '845355f4', 14 14 'dark-console.pkg.js' => '187792c2', 15 15 'differential.pkg.css' => '42a2334f', 16 - 'differential.pkg.js' => 'b57da3e7', 16 + 'differential.pkg.js' => '8f59bce2', 17 17 'diffusion.pkg.css' => '42c75c37', 18 18 'diffusion.pkg.js' => 'a98c0bf7', 19 19 'maniphest.pkg.css' => '35995d6d', ··· 380 380 'rsrc/js/application/dashboard/behavior-dashboard-query-panel-select.js' => '1e413dc9', 381 381 'rsrc/js/application/dashboard/behavior-dashboard-tab-panel.js' => '0116d3e8', 382 382 'rsrc/js/application/diff/DiffChangeset.js' => '0c083409', 383 - 'rsrc/js/application/diff/DiffChangesetList.js' => 'ac403c32', 383 + 'rsrc/js/application/diff/DiffChangesetList.js' => 'db615898', 384 384 'rsrc/js/application/diff/DiffInline.js' => 'b00168c1', 385 385 'rsrc/js/application/diff/DiffPathView.js' => '8207abf9', 386 386 'rsrc/js/application/diff/DiffTreeView.js' => '5d83623b', ··· 775 775 'phabricator-darkmessage' => '26cd4b73', 776 776 'phabricator-dashboard-css' => '5a205b9d', 777 777 'phabricator-diff-changeset' => '0c083409', 778 - 'phabricator-diff-changeset-list' => 'ac403c32', 778 + 'phabricator-diff-changeset-list' => 'db615898', 779 779 'phabricator-diff-inline' => 'b00168c1', 780 780 'phabricator-diff-path-view' => '8207abf9', 781 781 'phabricator-diff-tree-view' => '5d83623b', ··· 1911 1911 'javelin-dom', 1912 1912 'phabricator-notification', 1913 1913 ), 1914 - 'ac403c32' => array( 1915 - 'javelin-install', 1916 - 'phuix-button-view', 1917 - 'phabricator-diff-tree-view', 1918 - ), 1919 1914 'ad258e28' => array( 1920 1915 'javelin-behavior', 1921 1916 'javelin-dom', ··· 2123 2118 'javelin-behavior', 2124 2119 'javelin-uri', 2125 2120 'phabricator-notification', 2121 + ), 2122 + 'db615898' => array( 2123 + 'javelin-install', 2124 + 'phuix-button-view', 2125 + 'phabricator-diff-tree-view', 2126 2126 ), 2127 2127 'e150bd50' => array( 2128 2128 'javelin-behavior',
+1 -1
webroot/rsrc/js/application/diff/DiffChangesetList.js
··· 342 342 var inline = cursor.target; 343 343 if (inline.canReply()) { 344 344 this.setFocus(null); 345 - inline.reply(true); 345 + inline.reply(is_quote); 346 346 return; 347 347 } 348 348 }