@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix inverted check in audit triggers for "uninvolved owner"
Summary: See D20126. I was trying to be a little too cute here with the names and ended up confusing myself, then just tested the method behavior. :/
Test Plan: Persudaded by arguments in D20126.
Reviewers: amckinley
Reviewed By: amckinley
Differential Revision: https://secure.phabricator.com/D20135
+2
-2
+2
-2
src/applications/repository/worker/PhabricatorRepositoryCommitOwnersWorker.php
+2
-2
src/applications/repository/worker/PhabricatorRepositoryCommitOwnersWorker.php
···
174
174
// If auditing is configured to trigger on changes with no involved owner,
175
175
// check for an owner. If we don't find one, trigger an audit.
176
176
if ($audit_uninvolved) {
177
-
$commit_uninvolved = $this->isOwnerInvolved(
177
+
$owner_involved = $this->isOwnerInvolved(
178
178
$commit,
179
179
$package,
180
180
$author_phid,
181
181
$revision);
182
-
if ($commit_uninvolved) {
182
+
if (!$owner_involved) {
183
183
return true;
184
184
}
185
185
}