@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix an issue where scrolling down, then up, then down fails to show changeset header in Differential

Summary: Ref T13151. See PHI616. There's a bug where the current banner changeset isn't cleared correctly when we hide the banner.

Test Plan:
- View revision with several changesets.
- Scroll down slowly through first changeset until banner appears.
- Scroll up until banner disappears.
- Scroll back down.
- Before: banner fails to reappear (code still thinks it's visible and we don't want to update it).
- After: banner reappears correctly.

Reviewers: amckinley, jmeador

Reviewed By: jmeador

Maniphest Tasks: T13151

Differential Revision: https://secure.phabricator.com/D19474

+8 -7
+7 -7
resources/celerity/map.php
··· 12 12 'core.pkg.css' => '8e3d1fb7', 13 13 'core.pkg.js' => '2058ec09', 14 14 'differential.pkg.css' => '06dc617c', 15 - 'differential.pkg.js' => 'c2ca903a', 15 + 'differential.pkg.js' => 'ef19e026', 16 16 'diffusion.pkg.css' => 'a2d17c7d', 17 17 'diffusion.pkg.js' => '6134c5a1', 18 18 'maniphest.pkg.css' => '4845691a', ··· 373 373 'rsrc/js/application/dashboard/behavior-dashboard-query-panel-select.js' => '453c5375', 374 374 'rsrc/js/application/dashboard/behavior-dashboard-tab-panel.js' => 'd4eecc63', 375 375 'rsrc/js/application/diff/DiffChangeset.js' => 'b49b59d6', 376 - 'rsrc/js/application/diff/DiffChangesetList.js' => 'e74b7517', 376 + 'rsrc/js/application/diff/DiffChangesetList.js' => 'f0ffe8c3', 377 377 'rsrc/js/application/diff/DiffInline.js' => 'e83d28f3', 378 378 'rsrc/js/application/diff/behavior-preview-link.js' => '051c7832', 379 379 'rsrc/js/application/differential/behavior-comment-preview.js' => '51c5ad07', ··· 752 752 'phabricator-darkmessage' => 'c48cccdd', 753 753 'phabricator-dashboard-css' => 'fe5b1869', 754 754 'phabricator-diff-changeset' => 'b49b59d6', 755 - 'phabricator-diff-changeset-list' => 'e74b7517', 755 + 'phabricator-diff-changeset-list' => 'f0ffe8c3', 756 756 'phabricator-diff-inline' => 'e83d28f3', 757 757 'phabricator-drag-and-drop-file-upload' => '58dea2fa', 758 758 'phabricator-draggable-list' => 'bea6e7f4', ··· 2068 2068 'javelin-behavior', 2069 2069 'javelin-dom', 2070 2070 ), 2071 - 'e74b7517' => array( 2072 - 'javelin-install', 2073 - 'phuix-button-view', 2074 - ), 2075 2071 'e83d28f3' => array( 2076 2072 'javelin-dom', 2077 2073 ), ··· 2120 2116 'javelin-util', 2121 2117 'javelin-workflow', 2122 2118 'javelin-json', 2119 + ), 2120 + 'f0ffe8c3' => array( 2121 + 'javelin-install', 2122 + 'phuix-button-view', 2123 2123 ), 2124 2124 'f1ff5494' => array( 2125 2125 'phui-button-css',
+1
webroot/rsrc/js/application/diff/DiffChangesetList.js
··· 1381 1381 var changeset = this._getVisibleChangeset(); 1382 1382 1383 1383 if (!changeset) { 1384 + this._bannerChangeset = null; 1384 1385 JX.DOM.remove(node); 1385 1386 return; 1386 1387 }