@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Replace some manual class name strings with ::class keyword

Summary:
Replace classname strings in `isClassInstalled()` parameter value with the corresponding `::class` keyword.
This will enable static code analysis to throw "Class not found" if such a class did not exist.

`::class` is available since PHP 5.5: https://www.php.net/manual/en/language.oop5.basic.php#language.oop5.basic.class.class
`::class` returns the fully qualified classname including namespace, however we do not use PHP namespaces except in imported external libraries.

See similar previous patches.

Refs T15158

Test Plan: Browse random Phorge pages?

Reviewers: O1 Blessed Committers, mainframe98

Reviewed By: O1 Blessed Committers, mainframe98

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15158

Differential Revision: https://we.phorge.it/D26383

+54 -54
+1 -1
src/aphront/site/PhabricatorShortSite.php
··· 19 19 } 20 20 21 21 $phurl_installed = PhabricatorApplication::isClassInstalled( 22 - 'PhabricatorPhurlApplication'); 22 + PhabricatorPhurlApplication::class); 23 23 if (!$phurl_installed) { 24 24 return false; 25 25 }
+1 -1
src/applications/audit/mail/PhabricatorAuditMailReceiver.php
··· 4 4 5 5 public function isEnabled() { 6 6 return PhabricatorApplication::isClassInstalled( 7 - 'PhabricatorDiffusionApplication'); 7 + PhabricatorDiffusionApplication::class); 8 8 } 9 9 10 10 protected function getObjectPattern() {
+1 -1
src/applications/audit/query/PhabricatorCommitSearchEngine.php
··· 72 72 protected function buildCustomSearchFields() { 73 73 $show_audit_fields = (id(new PhabricatorAuditApplication())->isInstalled()); 74 74 $show_packages = PhabricatorApplication::isClassInstalled( 75 - 'PhabricatorPackagesApplication'); 75 + PhabricatorPackagesApplication::class); 76 76 return array( 77 77 id(new PhabricatorSearchDatasourceField()) 78 78 ->setLabel(pht('Responsible Users'))
+1 -1
src/applications/badges/mail/PhabricatorBadgesMailReceiver.php
··· 5 5 6 6 public function isEnabled() { 7 7 return PhabricatorApplication::isClassInstalled( 8 - 'PhabricatorBadgesApplication'); 8 + PhabricatorBadgesApplication::class); 9 9 } 10 10 11 11 protected function getObjectPattern() {
+2 -2
src/applications/calendar/mail/PhabricatorCalendarEventMailReceiver.php
··· 4 4 extends PhabricatorObjectMailReceiver { 5 5 6 6 public function isEnabled() { 7 - $app_class = 'PhabricatorCalendarApplication'; 8 - return PhabricatorApplication::isClassInstalled($app_class); 7 + return PhabricatorApplication::isClassInstalled( 8 + PhabricatorCalendarApplication::class); 9 9 } 10 10 11 11 protected function getObjectPattern() {
+1 -1
src/applications/calendar/notifications/PhabricatorCalendarNotificationEngine.php
··· 41 41 return; 42 42 } 43 43 44 - $calendar_class = 'PhabricatorCalendarApplication'; 44 + $calendar_class = PhabricatorCalendarApplication::class; 45 45 if (!PhabricatorApplication::isClassInstalled($calendar_class)) { 46 46 return; 47 47 }
+2 -2
src/applications/conduit/method/ConduitGetCapabilitiesConduitAPIMethod.php
··· 36 36 'sessionless', 37 37 ); 38 38 39 - $oauth_app = PhabricatorOAuthServerApplication::class; 40 - if (PhabricatorApplication::isClassInstalled($oauth_app)) { 39 + $oauth_class = PhabricatorOAuthServerApplication::class; 40 + if (PhabricatorApplication::isClassInstalled($oauth_class)) { 41 41 $authentication[] = 'oauth'; 42 42 } 43 43
+2 -2
src/applications/conpherence/mail/ConpherenceThreadMailReceiver.php
··· 4 4 extends PhabricatorObjectMailReceiver { 5 5 6 6 public function isEnabled() { 7 - $app_class = 'PhabricatorConpherenceApplication'; 8 - return PhabricatorApplication::isClassInstalled($app_class); 7 + return PhabricatorApplication::isClassInstalled( 8 + PhabricatorConpherenceApplication::class); 9 9 } 10 10 11 11 protected function getObjectPattern() {
+1 -1
src/applications/countdown/mail/PhabricatorCountdownMailReceiver.php
··· 5 5 6 6 public function isEnabled() { 7 7 return PhabricatorApplication::isClassInstalled( 8 - 'PhabricatorCountdownApplication'); 8 + PhabricatorCountdownApplication::class); 9 9 } 10 10 11 11 protected function getObjectPattern() {
+2 -2
src/applications/differential/customfield/DifferentialRequiredSignaturesField.php
··· 24 24 } 25 25 26 26 public static function loadForRevision($revision) { 27 - $app_legalpad = 'PhabricatorLegalpadApplication'; 28 - if (!PhabricatorApplication::isClassInstalled($app_legalpad)) { 27 + $legalpad_class = PhabricatorLegalpadApplication::class; 28 + if (!PhabricatorApplication::isClassInstalled($legalpad_class)) { 29 29 return array(); 30 30 } 31 31
+2 -2
src/applications/differential/editor/DifferentialTransactionEditor.php
··· 211 211 // "T123" or similar, automatically associate the commit with the 212 212 // task that the branch names. 213 213 214 - $maniphest = 'PhabricatorManiphestApplication'; 215 - if (PhabricatorApplication::isClassInstalled($maniphest)) { 214 + $maniphest_class = PhabricatorManiphestApplication::class; 215 + if (PhabricatorApplication::isClassInstalled($maniphest_class)) { 216 216 $diff = $this->requireDiff($xaction->getNewValue()); 217 217 $branch = $diff->getBranch(); 218 218
+1 -1
src/applications/differential/engineextension/DifferentialHovercardEngineExtension.php
··· 7 7 8 8 public function isExtensionEnabled() { 9 9 return PhabricatorApplication::isClassInstalled( 10 - 'PhabricatorDifferentialApplication'); 10 + PhabricatorDifferentialApplication::class); 11 11 } 12 12 13 13 public function getExtensionName() {
+1 -1
src/applications/differential/mail/DifferentialRevisionMailReceiver.php
··· 5 5 6 6 public function isEnabled() { 7 7 return PhabricatorApplication::isClassInstalled( 8 - 'PhabricatorDifferentialApplication'); 8 + PhabricatorDifferentialApplication::class); 9 9 } 10 10 11 11 protected function getObjectPattern() {
+1 -1
src/applications/diffusion/engineextension/DiffusionHovercardEngineExtension.php
··· 7 7 8 8 public function isExtensionEnabled() { 9 9 return PhabricatorApplication::isClassInstalled( 10 - 'PhabricatorDiffusionApplication'); 10 + PhabricatorDiffusionApplication::class); 11 11 } 12 12 13 13 public function getExtensionName() {
+2 -2
src/applications/drydock/blueprint/DrydockAlmanacServiceHostBlueprintImplementation.php
··· 7 7 private $freeBindings; 8 8 9 9 public function isEnabled() { 10 - $almanac_app = PhabricatorAlmanacApplication::class; 11 - return PhabricatorApplication::isClassInstalled($almanac_app); 10 + return PhabricatorApplication::isClassInstalled( 11 + PhabricatorAlmanacApplication::class); 12 12 } 13 13 14 14 public function getBlueprintName() {
+1 -1
src/applications/files/mail/FileMailReceiver.php
··· 4 4 5 5 public function isEnabled() { 6 6 return PhabricatorApplication::isClassInstalled( 7 - 'PhabricatorFilesApplication'); 7 + PhabricatorFilesApplication::class); 8 8 } 9 9 10 10 protected function getObjectPattern() {
+1 -1
src/applications/harbormaster/stepgroup/HarbormasterDrydockBuildStepGroup.php
··· 14 14 } 15 15 16 16 public function isEnabled() { 17 - $drydock_class = 'PhabricatorDrydockApplication'; 17 + $drydock_class = PhabricatorDrydockApplication::class; 18 18 return PhabricatorApplication::isClassInstalled($drydock_class); 19 19 } 20 20
+1 -1
src/applications/legalpad/mail/LegalpadMailReceiver.php
··· 4 4 5 5 public function isEnabled() { 6 6 return PhabricatorApplication::isClassInstalled( 7 - 'PhabricatorLegalpadApplication'); 7 + PhabricatorLegalpadApplication::class); 8 8 } 9 9 10 10 protected function getObjectPattern() {
+1 -1
src/applications/macro/mail/PhabricatorMacroMailReceiver.php
··· 4 4 5 5 public function isEnabled() { 6 6 return PhabricatorApplication::isClassInstalled( 7 - 'PhabricatorManiphestApplication'); 7 + PhabricatorManiphestApplication::class); 8 8 } 9 9 10 10 protected function getObjectPattern() {
+1 -1
src/applications/maniphest/engineextension/ManiphestHovercardEngineExtension.php
··· 7 7 8 8 public function isExtensionEnabled() { 9 9 return PhabricatorApplication::isClassInstalled( 10 - 'PhabricatorManiphestApplication'); 10 + PhabricatorManiphestApplication::class); 11 11 } 12 12 13 13 public function getExtensionName() {
+1 -1
src/applications/maniphest/mail/ManiphestTaskMailReceiver.php
··· 4 4 5 5 public function isEnabled() { 6 6 return PhabricatorApplication::isClassInstalled( 7 - 'PhabricatorManiphestApplication'); 7 + PhabricatorManiphestApplication::class); 8 8 } 9 9 10 10 protected function getObjectPattern() {
+1 -1
src/applications/oauthserver/panel/PhabricatorOAuthServerAuthorizationsSettingsPanel.php
··· 21 21 22 22 public function isEnabled() { 23 23 return PhabricatorApplication::isClassInstalled( 24 - 'PhabricatorOAuthServerApplication'); 24 + PhabricatorOAuthServerApplication::class); 25 25 } 26 26 27 27 public function processRequest(AphrontRequest $request) {
+1 -1
src/applications/owners/engineextension/PhabricatorOwnersHovercardEngineExtension.php
··· 7 7 8 8 public function isExtensionEnabled() { 9 9 return PhabricatorApplication::isClassInstalled( 10 - 'PhabricatorOwnersApplication'); 10 + PhabricatorOwnersApplication::class); 11 11 } 12 12 13 13 public function getExtensionName() {
+2 -2
src/applications/paste/mail/PasteMailReceiver.php
··· 3 3 final class PasteMailReceiver extends PhabricatorObjectMailReceiver { 4 4 5 5 public function isEnabled() { 6 - $app_class = 'PhabricatorPasteApplication'; 7 - return PhabricatorApplication::isClassInstalled($app_class); 6 + return PhabricatorApplication::isClassInstalled( 7 + PhabricatorPasteApplication::class); 8 8 } 9 9 10 10 protected function getObjectPattern() {
+1 -1
src/applications/people/customfield/PhabricatorUserStatusField.php
··· 23 23 24 24 public function isFieldEnabled() { 25 25 return PhabricatorApplication::isClassInstalled( 26 - 'PhabricatorCalendarApplication'); 26 + PhabricatorCalendarApplication::class); 27 27 } 28 28 29 29 public function renderPropertyViewValue(array $handles) {
+1 -1
src/applications/phame/mail/PhamePostMailReceiver.php
··· 5 5 6 6 public function isEnabled() { 7 7 return PhabricatorApplication::isClassInstalled( 8 - 'PhabricatorPhameApplication'); 8 + PhabricatorPhameApplication::class); 9 9 } 10 10 11 11 protected function getObjectPattern() {
+1 -1
src/applications/phame/site/PhameSite.php
··· 10 10 } 11 11 12 12 $phame_installed = PhabricatorApplication::isClassInstalled( 13 - 'PhabricatorPhameApplication'); 13 + PhabricatorPhameApplication::class); 14 14 if (!$phame_installed) { 15 15 // Don't activate Phame if the the application is uninstalled. 16 16 return false;
+2 -2
src/applications/pholio/mail/PholioMockMailReceiver.php
··· 3 3 final class PholioMockMailReceiver extends PhabricatorObjectMailReceiver { 4 4 5 5 public function isEnabled() { 6 - $app_class = 'PhabricatorPholioApplication'; 7 - return PhabricatorApplication::isClassInstalled($app_class); 6 + return PhabricatorApplication::isClassInstalled( 7 + PhabricatorPholioApplication::class); 8 8 } 9 9 10 10 protected function getObjectPattern() {
+1 -1
src/applications/phriction/controller/PhrictionController.php
··· 37 37 protected function buildApplicationCrumbs() { 38 38 $crumbs = parent::buildApplicationCrumbs(); 39 39 40 - if (get_class($this) != 'PhrictionListController') { 40 + if (get_class($this) != PhrictionListController::class) { 41 41 $crumbs->addAction( 42 42 id(new PHUIListItemView()) 43 43 ->setName(pht('Index'))
+1 -1
src/applications/phriction/engineextension/PhrictionHovercardEngineExtension.php
··· 7 7 8 8 public function isExtensionEnabled() { 9 9 return PhabricatorApplication::isClassInstalled( 10 - 'PhabricatorPhrictionApplication'); 10 + PhabricatorPhrictionApplication::class); 11 11 } 12 12 13 13 public function getExtensionName() {
+1 -1
src/applications/phurl/mail/PhabricatorPhurlURLMailReceiver.php
··· 5 5 6 6 public function isEnabled() { 7 7 return PhabricatorApplication::isClassInstalled( 8 - 'PhabricatorPhurlApplication'); 8 + PhabricatorPhurlApplication::class); 9 9 } 10 10 11 11 protected function getObjectPattern() {
+2 -2
src/applications/ponder/mail/PonderAnswerMailReceiver.php
··· 3 3 final class PonderAnswerMailReceiver extends PhabricatorObjectMailReceiver { 4 4 5 5 public function isEnabled() { 6 - $app_class = 'PhabricatorPonderApplication'; 7 - return PhabricatorApplication::isClassInstalled($app_class); 6 + return PhabricatorApplication::isClassInstalled( 7 + PhabricatorPonderApplication::class); 8 8 } 9 9 10 10 protected function getObjectPattern() {
+2 -2
src/applications/ponder/mail/PonderQuestionMailReceiver.php
··· 3 3 final class PonderQuestionMailReceiver extends PhabricatorObjectMailReceiver { 4 4 5 5 public function isEnabled() { 6 - $app_class = 'PhabricatorPonderApplication'; 7 - return PhabricatorApplication::isClassInstalled($app_class); 6 + return PhabricatorApplication::isClassInstalled( 7 + PhabricatorPonderApplication::class); 8 8 } 9 9 10 10 protected function getObjectPattern() {
+1 -1
src/applications/project/engineextension/PhabricatorProjectsEditEngineExtension.php
··· 15 15 16 16 public function isExtensionEnabled() { 17 17 return PhabricatorApplication::isClassInstalled( 18 - 'PhabricatorProjectApplication'); 18 + PhabricatorProjectApplication::class); 19 19 } 20 20 21 21 public function getExtensionName() {
+1 -1
src/applications/project/engineextension/PhabricatorProjectsSearchEngineExtension.php
··· 7 7 8 8 public function isExtensionEnabled() { 9 9 return PhabricatorApplication::isClassInstalled( 10 - 'PhabricatorProjectApplication'); 10 + PhabricatorProjectApplication::class); 11 11 } 12 12 13 13 public function getExtensionName() {
+2 -2
src/applications/repository/worker/PhabricatorRepositoryCommitPublishWorker.php
··· 428 428 PhabricatorUser $actor, 429 429 PhabricatorRepositoryCommit $commit) { 430 430 431 - $differential = 'PhabricatorDifferentialApplication'; 432 - if (!PhabricatorApplication::isClassInstalled($differential)) { 431 + $differential_class = PhabricatorDifferentialApplication::class; 432 + if (!PhabricatorApplication::isClassInstalled($differential_class)) { 433 433 return; 434 434 } 435 435
+1 -1
src/applications/search/controller/PhabricatorSearchDefaultController.php
··· 7 7 $viewer = $this->getViewer(); 8 8 $engine_class = $request->getURIData('engine'); 9 9 10 - $base_class = 'PhabricatorApplicationSearchEngine'; 10 + $base_class = PhabricatorApplicationSearchEngine::class; 11 11 if (!is_subclass_of($engine_class, $base_class)) { 12 12 return new Aphront400Response(); 13 13 }
+1 -1
src/applications/settings/panel/PhabricatorNotificationsSettingsPanel.php
··· 10 10 } 11 11 12 12 return PhabricatorApplication::isClassInstalled( 13 - 'PhabricatorNotificationsApplication'); 13 + PhabricatorNotificationsApplication::class); 14 14 } 15 15 16 16 public function getPanelKey() {
+1 -1
src/applications/slowvote/mail/PhabricatorSlowvoteMailReceiver.php
··· 5 5 6 6 public function isEnabled() { 7 7 return PhabricatorApplication::isClassInstalled( 8 - 'PhabricatorSlowvoteApplication'); 8 + PhabricatorSlowvoteApplication::class); 9 9 } 10 10 11 11 protected function getObjectPattern() {
+1 -1
src/applications/spaces/engineextension/PhabricatorSpacesSearchEngineExtension.php
··· 7 7 8 8 public function isExtensionEnabled() { 9 9 return PhabricatorApplication::isClassInstalled( 10 - 'PhabricatorSpacesApplication'); 10 + PhabricatorSpacesApplication::class); 11 11 } 12 12 13 13 public function getExtensionName() {
+1 -1
src/applications/subscriptions/engineextension/PhabricatorSubscriptionsSearchEngineExtension.php
··· 7 7 8 8 public function isExtensionEnabled() { 9 9 return PhabricatorApplication::isClassInstalled( 10 - 'PhabricatorSubscriptionsApplication'); 10 + PhabricatorSubscriptionsApplication::class); 11 11 } 12 12 13 13 public function getExtensionName() {
+2 -2
src/infrastructure/daemon/workers/PhabricatorTriggerDaemon.php
··· 415 415 416 416 417 417 private function updateNuanceImportCursors() { 418 - $nuance_app = PhabricatorNuanceApplication::class; 419 - if (!PhabricatorApplication::isClassInstalled($nuance_app)) { 418 + $nuance_class = PhabricatorNuanceApplication::class; 419 + if (!PhabricatorApplication::isClassInstalled($nuance_class)) { 420 420 return false; 421 421 } 422 422