@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix method visibility for `AphrontFormControl` methods
Summary: Ref T6822.
Test Plan: Visual inspection. These methods are only called from within the `AphrontFormControl` class.
Reviewers: #blessed_reviewers, epriestley
Reviewed By: #blessed_reviewers, epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T6822
Differential Revision: https://secure.phabricator.com/D11249
+6
-6
+2
-2
src/applications/flag/view/PhabricatorFlagSelectControl.php
+2
-2
src/applications/flag/view/PhabricatorFlagSelectControl.php
···
2
2
3
3
final class PhabricatorFlagSelectControl extends AphrontFormControl {
4
4
5
-
public function getCustomControlClass() {
5
+
protected function getCustomControlClass() {
6
6
return 'phabricator-flag-select-control';
7
7
}
8
8
9
-
public function renderInput() {
9
+
protected function renderInput() {
10
10
require_celerity_resource('phabricator-flag-css');
11
11
12
12
$colors = PhabricatorFlagColor::getColorNameMap();
+2
-2
src/applications/releeph/view/branch/ReleephBranchPreviewView.php
+2
-2
src/applications/releeph/view/branch/ReleephBranchPreviewView.php
···
17
17
return $this;
18
18
}
19
19
20
-
public function getCustomControlClass() {
20
+
protected function getCustomControlClass() {
21
21
require_celerity_resource('releeph-preview-branch');
22
22
return 'releeph-preview-branch';
23
23
}
24
24
25
-
public function renderInput() {
25
+
protected function renderInput() {
26
26
static $required_params = array(
27
27
'arcProjectID',
28
28
'projectName',
+2
-2
src/applications/releeph/view/request/ReleephRequestTypeaheadControl.php
+2
-2
src/applications/releeph/view/request/ReleephRequestTypeaheadControl.php
···
17
17
return $this;
18
18
}
19
19
20
-
public function getCustomControlClass() {
20
+
protected function getCustomControlClass() {
21
21
return 'releeph-request-typeahead';
22
22
}
23
23
24
-
public function renderInput() {
24
+
protected function renderInput() {
25
25
$id = celerity_generate_unique_node_id();
26
26
27
27
$div = phutil_tag(