@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Audit Feed: less verbose when the author is the committer
Summary:
If the author and the committer are the same person, do not show them twice.
From:
UsernameFoo committed <commit hash>: <commit msg> (authored by UsernameFoo).
To:
UsernameFoo committed <commit hash>: <commit msg>
This only affects the feed.
| Before | After |
|-----------|-----------|
| {F342758} | {F342764} |
Closes T15528
Test Plan: Do some mixed commits and visit /feed/query/all/. No nuclear implosions.
Reviewers: O1 Blessed Committers, speck
Reviewed By: O1 Blessed Committers, speck
Subscribers: speck, tobiaswiese, Matthew, Cigaryno
Maniphest Tasks: T15528
Differential Revision: https://we.phorge.it/D25421
+11
-1
+11
-1
src/applications/audit/storage/PhabricatorAuditTransaction.php
+11
-1
src/applications/audit/storage/PhabricatorAuditTransaction.php
···
338
338
$author = null;
339
339
}
340
340
341
-
if ($author) {
341
+
// Show both Author and Committer only if they are different.
342
+
$show_both = $author && $committer;
343
+
if ($show_both) {
344
+
if ($new['authorPHID']) {
345
+
$show_both = $new['authorPHID'] !== $new['committerPHID'];
346
+
} else if (phutil_nonempty_string($new['authorName'])) {
347
+
$show_both = $new['authorName'] !== $new['committerName'];
348
+
}
349
+
}
350
+
351
+
if ($show_both) {
342
352
$title = pht(
343
353
'%s committed %s (authored by %s).',
344
354
$committer,