@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove "Reviewed By" Differential field
Summary: Ref T11114. This is replaced by `DifferentialReviewedByCommitMessageField.php`.
Test Plan:
- Used `differential.getcommitmessage` to query an accepted revision, saw "Reviewed By".
- Grepped for removed class name.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T11114
Differential Revision: https://secure.phabricator.com/D17079
-71
-2
src/__phutil_library_map__.php
-2
src/__phutil_library_map__.php
···
494
494
'DifferentialRevertPlanCommitMessageField' => 'applications/differential/field/DifferentialRevertPlanCommitMessageField.php',
495
495
'DifferentialRevertPlanField' => 'applications/differential/customfield/DifferentialRevertPlanField.php',
496
496
'DifferentialReviewedByCommitMessageField' => 'applications/differential/field/DifferentialReviewedByCommitMessageField.php',
497
-
'DifferentialReviewedByField' => 'applications/differential/customfield/DifferentialReviewedByField.php',
498
497
'DifferentialReviewerDatasource' => 'applications/differential/typeahead/DifferentialReviewerDatasource.php',
499
498
'DifferentialReviewerForRevisionEdgeType' => 'applications/differential/edge/DifferentialReviewerForRevisionEdgeType.php',
500
499
'DifferentialReviewerProxy' => 'applications/differential/storage/DifferentialReviewerProxy.php',
···
5146
5145
'DifferentialRevertPlanCommitMessageField' => 'DifferentialCommitMessageCustomField',
5147
5146
'DifferentialRevertPlanField' => 'DifferentialStoredCustomField',
5148
5147
'DifferentialReviewedByCommitMessageField' => 'DifferentialCommitMessageField',
5149
-
'DifferentialReviewedByField' => 'DifferentialCoreCustomField',
5150
5148
'DifferentialReviewerDatasource' => 'PhabricatorTypeaheadCompositeDatasource',
5151
5149
'DifferentialReviewerForRevisionEdgeType' => 'PhabricatorEdgeType',
5152
5150
'DifferentialReviewerProxy' => 'Phobject',
-1
src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
-1
src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
-68
src/applications/differential/customfield/DifferentialReviewedByField.php
-68
src/applications/differential/customfield/DifferentialReviewedByField.php
···
1
-
<?php
2
-
3
-
final class DifferentialReviewedByField
4
-
extends DifferentialCoreCustomField {
5
-
6
-
public function getFieldKey() {
7
-
return 'differential:reviewed-by';
8
-
}
9
-
10
-
public function getFieldKeyForConduit() {
11
-
return 'reviewedByPHIDs';
12
-
}
13
-
14
-
public function getFieldName() {
15
-
return pht('Reviewed By');
16
-
}
17
-
18
-
public function getFieldDescription() {
19
-
return pht('Records accepting reviewers in the durable message.');
20
-
}
21
-
22
-
public function shouldAppearInApplicationTransactions() {
23
-
return false;
24
-
}
25
-
26
-
public function canDisableField() {
27
-
return true;
28
-
}
29
-
30
-
protected function readValueFromRevision(
31
-
DifferentialRevision $revision) {
32
-
33
-
$phids = array();
34
-
foreach ($revision->getReviewerStatus() as $reviewer) {
35
-
switch ($reviewer->getStatus()) {
36
-
case DifferentialReviewerStatus::STATUS_ACCEPTED:
37
-
case DifferentialReviewerStatus::STATUS_ACCEPTED_OLDER:
38
-
$phids[] = $reviewer->getReviewerPHID();
39
-
break;
40
-
}
41
-
}
42
-
43
-
return $phids;
44
-
}
45
-
46
-
public function shouldAppearInCommitMessage() {
47
-
return true;
48
-
}
49
-
50
-
public function parseValueFromCommitMessage($value) {
51
-
return $this->parseObjectList(
52
-
$value,
53
-
array(
54
-
PhabricatorPeopleUserPHIDType::TYPECONST,
55
-
PhabricatorProjectProjectPHIDType::TYPECONST,
56
-
),
57
-
$allow_partial = true);
58
-
}
59
-
60
-
public function getRequiredHandlePHIDsForCommitMessage() {
61
-
return $this->getValue();
62
-
}
63
-
64
-
public function renderCommitMessageValue(array $handles) {
65
-
return $this->renderObjectList($handles);
66
-
}
67
-
68
-
}