@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Diffusion - maybe fix import spam bug
Summary: Ref T6350. I just set up a repository to import secure.phabricator.com/P and saw an error in my error logs about this, creating a fatal around when we publish feed stories. this is late enough in the editor code path I could see it firing again and again and again...
Test Plan: the first phabricator commit ever only had one duplicated transaction before i applied this patch. its yet to do it again. otherwise, ask some users with the issue to deploy it and see if it fixes things for them too.
Reviewers: epriestley, chad
Reviewed By: chad
Subscribers: Korvin, epriestley
Maniphest Tasks: T6350
Differential Revision: https://secure.phabricator.com/D10729
+1
-1
+1
-1
src/applications/feed/PhabricatorFeedStoryPublisher.php
+1
-1
src/applications/feed/PhabricatorFeedStoryPublisher.php
···
121
121
}
122
122
123
123
$subscribed_phids = $this->subscribedPHIDs;
124
-
$subscribed_phids = $this->filterSubscribedPHIDs($subscribed_phids);
125
124
if ($subscribed_phids) {
125
+
$subscribed_phids = $this->filterSubscribedPHIDs($subscribed_phids);
126
126
$this->insertNotifications($chrono_key, $subscribed_phids);
127
127
$this->sendNotification($chrono_key, $subscribed_phids);
128
128
}